openETCS / modeling

WP3 Top Level Project: to cover all tasks related with modeling
31 stars 42 forks source link

Linking consistency errors on track #911

Closed UweSteinkeFromSiemens closed 8 years ago

UweSteinkeFromSiemens commented 8 years ago

The following linking consistency errors occur while traveling along the track:

I stop here, since the track layout from the shown range on needs readjustment.

BerndHekele commented 8 years ago

Hi Uwe, I did not get any "eerors" from your function when passing these balises. How is this possible?

BerndHekele commented 8 years ago

I now also see these errors. Can you please have a look at this problem: @JakobGartner

JakobGartner commented 8 years ago

@Rainer-Lampatzer has pointed me to the possible source of the error: In US_13, there was a lazy copy and paste error which made that the 3rd MA (which actually shortens the EOA) came with the wrong NID_LRBG.

Let me know if a problem persists

BerndHekele commented 8 years ago

We are driving US1-12 and the problem is still open. I see two problems

  1. BGs 370 and 371 are in wrong sequence in the linking data.
  2. calcTrainPosition stays confused if a wrong balise has been passed. The track: image

And linking: image

BerndHekele commented 8 years ago

One additional remark: I dont see any problems in the new track at balises before 341.

JakobGartner commented 8 years ago

Lets be precise about OLD and NEW OLD: US1-12 NEW: US13-16

I have re-checked the data defined in the track model for US1-12 and the data are defined as follows:

screen shot 2015-11-13 at 13 45 36

I don't really understand how they can get inverted.

jokaICS commented 8 years ago

Hmm, could this be due to an issue with q_linkorientation? BG370 and BG372 are passed in nominal direction, whereas BG371 and 374 are passed in reverse direction.

BerndHekele commented 8 years ago

Update on Statement regarding BG 351: If I run the model with optimisation level 1 I get the "missed" error at position (nominal) 361726. image

BerndHekele commented 8 years ago

Data received at LRBG 362:

JakobGartner commented 8 years ago

These data differ from the ones defined on the track.

On 13 Nov 2015, at 15:01, Bernd Hekele notifications@github.com wrote:

Data received at LRBG 364:

element 367 is twice in the input. 370 and 371 are in correct order https://cloud.githubusercontent.com/assets/3288918/11147488/89ed43d6-8a16-11e5-99a5-d4fb82dc9cae.png BGs at this position have gaps between 367 and 341 are missing BGs.: https://cloud.githubusercontent.com/assets/3288918/11147584/3d89dcba-8a17-11e5-974c-19d2daca3622.png — Reply to this email directly or view it on GitHub https://github.com/openETCS/modeling/issues/911#issuecomment-156438160.

BerndHekele commented 8 years ago

The famouse filter is not involved in this function. We are talking about elements of linking data at LRBG 362.

JakobGartner commented 8 years ago

OK, you wrote 364

indeed there is a problem with P5 at 363, will check and correct ASAP

On 13 Nov 2015, at 15:09, Bernd Hekele notifications@github.com wrote:

The famouse filter is not involved in this function. We are talking about elements of linking data at LRBG 362.

— Reply to this email directly or view it on GitHub https://github.com/openETCS/modeling/issues/911#issuecomment-156441793.

BerndHekele commented 8 years ago

I now reached LRBG 364. Obviously, the incorrect data at LRBG 362 results in a wrong linking list which is nice cause we can reproduce the problem.: image

The data received in P5 is ok: image

BerndHekele commented 8 years ago

I was confused with this extra information at LRBG 363. I did not expect the whole data being repeated.

JakobGartner commented 8 years ago

yes.

this is how it is on the track.

the copy/paste error that lead top double BG367 and other problems is fixed

On 13 Nov 2015, at 15:14, Bernd Hekele notifications@github.com wrote:

I was confused with this extra information at LRBG 363. I did not expect the whole data being repeated.

— Reply to this email directly or view it on GitHub https://github.com/openETCS/modeling/issues/911#issuecomment-156443496.

BerndHekele commented 8 years ago

I'm a bit nervouse about the different behaviour at balise 351. here, we had an impact due to different code generator options. Are you sure information is correct at this position?

BerndHekele commented 8 years ago

We have another problem at 381 - again, the orer is incorrect (381, 382). I'm now checking the data defined before this position. At LRBG371 the last element confuses me: image Same situation at LRBG 364 - last element seems to be incomplete.

JakobGartner commented 8 years ago

I will check on 381

on 371, indeed the value is 0 in the JRU data.

I will see what to do:

On 13 Nov 2015, at 16:30, Bernd Hekele notifications@github.com wrote:

We have another problem at 381 - again, the orer is incorrect (381, 382). I'm now checking the data defined before this position. At LRBG371 the last element confuses me: https://cloud.githubusercontent.com/assets/3288918/11149454/21965fc2-8a23-11e5-9816-ace44989c871.png Same situation at LRBG 364 - last element seems to be incomplete.

— Reply to this email directly or view it on GitHub https://github.com/openETCS/modeling/issues/911#issuecomment-156464206.

BerndHekele commented 8 years ago

In principle 0 is valid as a BG.

BerndHekele commented 8 years ago

I'm now at LRBG 364. The data from track look fine, but the BGs have a gap (BG 374 is missing in the list: Uwe's list: image

Input from track: image image

JakobGartner commented 8 years ago

screen shot 2015-11-13 at 17 19 54

BerndHekele commented 8 years ago

Next Update at LRBG 42600371. Now the data get's confused: BGs: image

Again, the input look nice in this situation: image

BerndHekele commented 8 years ago

I will ask Uwe for Support on this issue on Monday...

BerndHekele commented 8 years ago

Another positioning Error in the rear part of the track (BG438) image

JakobGartner commented 8 years ago

fixed

On 13 Nov 2015, at 18:05, Bernd Hekele notifications@github.com wrote:

Another positioning Error in the rear part of the track (BG438) https://cloud.githubusercontent.com/assets/3288918/11152118/0c573f88-8a31-11e5-88f6-8d5079c6d24f.png — Reply to this email directly or view it on GitHub https://github.com/openETCS/modeling/issues/911#issuecomment-156489247.

BerndHekele commented 8 years ago

@UweSteinkeFromSiemens : In this place the wrong sequence is seen for the first time after BG 364: image

BerndHekele commented 8 years ago

Looking into the model indexOfBG_onTrack_itr you get the following logic: image

which logic I don't quite understand (which location is compared here?

UweSteinkeFromSiemens commented 8 years ago

Dear Bernd, I'm on a business trip to Munich during the next week. Unfortunately, I will be offline completely on Monday and Tuesday. The next opportunity for me to analyze the problem is on Wednesday (perhaps at the Völckerstr. 5) or on Thursday.

BerndHekele commented 8 years ago

Dear Uwe, I'm fine with your proposal. I have the feelinmg the problem is triggered by some data inconsistency in the linking data which I did not find so far. I will try to digg a bit deaper to prepare your stop in Munich Völckerstrasse.

UweSteinkeFromSiemens commented 8 years ago

Yes, that' also my Impression. The inconsistency in the linking data has to be fixed anyway. The problem to maintain the correct order of BGs in inconsistent linking scenarios can be fixed independently. By the way, the latter is not so easy and typically requires a safety analysis before to answer questions of required robustness against misplaced BGs, multiple BGs with the same ID, linking inconsistencies, multiple announcements of the same BG at different locations, wrong ordering etc. This seems to be more than what is specified regarding linking consistency in SRS.

ghost commented 8 years ago

For the MA and the related P005 received at BG364, I have done an analysis:

--> segment 29 of JRU data in P005 received with NID_LRBG 426,364 yields to the corrected position of BG 393.

----> I have corrected the incomplete linking data.

Conclusion. It seems that the JRU data are illustrating a track which is was not fully engineered and validated during the travel. I will document that in my track model doc.

I have pushed the solution

I can not at all reproduce any of the other problems on the track model level. The track model is consistent with the JRU data as far as linking is concerned. (which does not totally exclude single errors, but for example there is nowhere a switch of BG 370 and BG371.

BerndHekele commented 8 years ago

@UweSteinkeFromSiemens : Dear Uwe, I had a closer look at the way the linking information is processed. I currently have the following understanding of the situation (based on the attached symptoms):

image

image

UweSteinkeFromSiemens commented 8 years ago

@BerndHekele : That's great, thank's a lot for your analysis.

Announcing a BG already passed in rear of the train is completely useless, but without no doubt calculateTrainPosition should be robust against it. When implementing I was not aware of it. I will fix it asap, when I get a valuable internet access.
In fact, as I stated above, it should be clarified as part of a later follow-up project, which other useless or weird scenarios must be taken into account.

JakobGartner commented 8 years ago

This seems to be a very standard scenario, as ALL the MAs we receive on the track come AFTER passing the LRBG.

It seems also (I have seen that from looking at the unused JRU data we have) that only specific BGs are used as LRBGs. They are all somehow related to specific features on the track (points, signals).

I had the same issue with the other track related data, that was part of my 1st learning curve in TrackAtlas.

There is a 2-step processing in TrackAtlas:

On 16 Nov 2015, at 19:08, Uwe Steinke notifications@github.com wrote:

@BerndHekele https://github.com/BerndHekele : That's great, thank's a lot for your analysis.

Announcing a BG already passed in rear of the train is completely useless, but without no doubt calculateTrainPosition should be robust against it. When implementing I was not aware of it. I will fix it asap, when I get a valuable internet access.

In fact, as I stated above, it should be clarified as part of a later follow-up project, which other useless or weird scenarios must be taken into account.

— Reply to this email directly or view it on GitHub https://github.com/openETCS/modeling/issues/911#issuecomment-157122333.

UweSteinkeFromSiemens commented 8 years ago

Dear @JakobGartner, the situation for MAs is comprehensible different: A LRBG must have been passed by the train and reported to the RBC, before it is allowed to be used by the RBC as a reference BG. In contrast, announcing a BG already been passed at most may reduce location uncertainty a little, but is otherwise useless. Since this behaviour is not specified - as far a I know - we are about to investigate the system by observation ...

JakobGartner commented 8 years ago

the Packet 5 is sent as part of a Message 3, consistently.

That is why I said “The MAs are received…”

The first MA (with linking data) is sent before the level transition, then again at the level transition with identical data; but in both cases after passing the ref LRBG

Yes, we are discovering the track by driving over it :-) and encounter many nice surprises

On 16 Nov 2015, at 20:09, Uwe Steinke notifications@github.com wrote:

Dear @JakobGartner https://github.com/JakobGartner, the situation for MAs is comprehensible different: A LRBG must have been passed by the train and reported to the RBC, before it is allowed to be used by the RBC as a reference BG. In contrast, announcing a BG already been passed at most may reduce location uncertainty a little, but is otherwise useless. Since this behaviour is not specified - as far a I know - we are about to investigate the system by observation ...

— Reply to this email directly or view it on GitHub https://github.com/openETCS/modeling/issues/911#issuecomment-157138404.

UweSteinkeFromSiemens commented 8 years ago

This issue is followed up by #926, #927 and can be closed from my point of view.