search

openETCS / modeling

WP3 Top Level Project: to cover all tasks related with modeling
31 stars 42 forks source link

calculateTrainPosition: dynamic re-arrangement of BGs on track fails #927

Open UweSteinkeFromSiemens opened 8 years ago

UweSteinkeFromSiemens commented 8 years ago

When an already passed BG is (re-)announced via radio, this in some situations causes an unintended re-arrangement of BGs in the list of BGs, calculateTrainPosition provides.

The bug results in some BGs disappearing from the list or hopping around. (By the way: @BerndHekele: It's not comprehensible for me, why the EVC on the track is robust against these effects, even when the error flags are ignored.)

A bug patch is provided by disabling the re-arrangement function for now, so that the list of BGs is maintained correctly for the needs of the Utrecht-Amsterdam track.

The bug has to be fixed by a correction of addAnnouncedBGs.mergeBGsOnTrack.mergeBGOnTrack.indexOfBGOnTrack and re-enabling the re-arrangement in addAnnouncedBGs.mergeBGsOnTrack.mergeBGOnTrack. Previously, the need and detailed requirements of a re-arrangement function should be figured out. The bug fix can be left over for post-openETCS ages.

BerndHekele commented 8 years ago

Hi Uwe, can you give an update on the status of this correction? We are using the actual version of your code and did not find any new problems so far. Can we close the issue after testing?

UweSteinkeFromSiemens commented 8 years ago

We have a patch, but not a fix. As I wrote above, the fix should take the requirements to re-arrangement into account, which are not known yet. Therefore, this issue should be left open for post-openETCS project ages.

UweSteinkeFromSiemens commented 8 years ago

No further action required during the remaining duration of the openETCS project. Therefore, downgraded to later enhancement.