search

openETCS / modeling

WP3 Top Level Project: to cover all tasks related with modeling
31 stars 42 forks source link

Position report: incorrect value for v_train #952

Closed jokaICS closed 8 years ago

jokaICS commented 8 years ago

It seems to me that the value for v_train in P000/P001 is incorrect: for a speed of ~10 km/h P000 reports v_train=58 instead of v_train=2 (i.e. v is multiplied by 5 instead of divided by 5).

JakobGartner commented 8 years ago

Will have a look

(You work too long.)

On 01.12.2015, at 22:46, Johannes Kastner notifications@github.com wrote:

It seems to me that the value for v_train in P000/P001 is incorrect: for a speed of ~10 km/h P000 reports v_train=58 instead of v_train=2 (i.e. v is multiplied by 5 instead of divided by 5).

— Reply to this email directly or view it on GitHub.

BerndHekele commented 8 years ago

I checked the implementation in ProvidePosition Report - this is correct. @JakobGartner Cab we have a correction in the track messages?

JakobGartner commented 8 years ago

The issue is here (probably, if I understand the position report implementation right) that V_TRAIN comes in cm/s and the TrackMessages library expects in km/h. The operator CAST_V_TRAIN_to_Int is actually dividing by 5. Can you confirm this theory? Question...: The V_TRAIN built by ProvidePositionReport has which scaling?

BerndHekele commented 8 years ago

I provided a correction in the position-report.

jokaICS commented 8 years ago

Solved.