openETCS / validation

WP4: Validation and verification strategy
8 stars 22 forks source link

Calculate Train Position: Conclusions from Train Positioning Closing Session #238

Closed UweSteinkeFromSiemens closed 9 years ago

UweSteinkeFromSiemens commented 9 years ago

This issue refers to #227 and https://github.com/openETCS/validation/blob/master/MinutesOfMeeting/141028_Verification_Closing_Session_Train_Positioning/A-D-VerfRprt-Train-Position-141028-V01.pdf.

The intention is to structure the cooperation for fixing the conclusions from the report:

Differences within the simulation and implementation has been detected and the two approaches have to be merged (Jan: Specify, Uwe: Implement)

For contribution: @JanWelvaarts , @VNuhaan , cc: @janWelte , @MarcBehrens , @JakobGartner

UweSteinkeFromSiemens commented 9 years ago

To 3. + 5.: The input and output data of the implementation are specified in https://github.com/openETCS/modeling/blob/master/model/Scade/System/ObuFunctions/ManageLocationRelatedInformation/TrainPosition/CalculateTrainPosition/GeneratedDocuments/CalculateTrainPosition_Interface.pdf.

UweSteinkeFromSiemens commented 9 years ago

To 1., 2., 8., 9.,12 and #227:

Matching the calculation algorithms:

The two existing train position calculation algorithms from @JanWelvaarts and @UweSteinkeFromSiemens have been matched in https://github.com/openETCS/modeling/blob/6b1ca72f3f6ec2ba77b5ad4216ed262b0eb0ce2c/openETCS%20ArchitectureAndDesign/Work%20Groups/Group%204/CalculateTrainPosition/Calculations/MatchingTrainPositionCalculationAlgorithms.pdf

MarcBehrens commented 9 years ago

going through the open points at the small cluster meeting together with @UweSteinkeFromSiemens

  1. concerning the data structures it is defined inside the 2nd/ 3rd iteration. Please adjust the design and the model here for the upcoming iteration @UweSteinkeFromSiemens @BaseliyosJacob
  2. the national values are not implemented inside scade for the first iteration (Design decision)
  3. Question: Is the reason behind this to avoid the floating point? Is fixed point explicitly ruled out? Please clarify the requirements here! @BerndHekele
  4. see 6., after discussion the need of higher resolution the proof of the sufficiency is needed here. Inside implementation and design - does this refer to the messages transferred or the internal calculation, and refers to 6. Please provide clarification on design side.
  5. Constraints on the inaccuracies have to be assumed as a hypothesis for later HW integration. This is a hint to the design to respect.
  6. postponed to the next iteration by the design.
  7. see 10.
  8. The state: power off and power on (start-up position) is missing inside the model.
  9. Not part of the implementation, see 10.
  10. Assigned to @jakobgartner
MarcBehrens commented 9 years ago

answer to 6: According to D2.4 Chapter 7.4.2 floating point is ruled out within the OBU.

point 7 is a design decision documented inside the basic types library: Obu_BasicTypes: L_internal_Type

point 15 will be covered in the TrackAtlas