janWelte
commented
9 years ago Architecture verification review related to ADD document chapter
relating to modeling issue https://github.com/openETCS/modeling/issues/307
relating to chapter:
- 4.1.3.1 Receive_TrackSide_Msg
- 4.1.3.2.1 Component Requirements
of this document: openETCS Architecture and Design Specification
ADD:
SCADE designer [Name,affiliation]
Finding:
- [ ] Please indicate who is the designer of this function.
ADD:
The function passes a balise telegram without major changes of the information to the next entity for collecting the balise group information.
Finding:
- [ ] Which is the next function.
- [ ] Which of the functions checks for repeated balise telegrams (or changed telegrams).
- [ ] At which point does this functions transmits the array of telegrams to the next function.
ADD:
Only packets used inside the current model are passed via the interface
Finding:
- [ ] Packets to be passed should be named.
- [ ] What is done with all other packets?
ADD:
Linking Information. Linking Information is added to the linking array starting from index 0 without gaps.
Finding:
- [ ] Indicate the reason, why linking information are processed here (and no other iteration packet), although it is stated that the function shall not process information from the packets.
ADD: `Elements are stored according to the order given by the telegram sequence.
... Subset-026, Chapter 3.4.2: Determining the orientation`
The Standard says: Every BG has an orientation based on its co-ordinate system, which has to be defined whether the BG has one or more balises. (3.4.2)
Finding:
- [ ] Is this the sequence the telegrams are received by the BTM or the sequence given by the BG orientation.
- [ ] Does this function already assigns the coordinate system or is this done later (specifically relevant for single balise groups), respectively is 3.4.2 covered at this function completely
ADD:
Subset-026, Chapter 4.2.2, 4.2.4, 4.2.9: Interface to the BTM
Finding:
- [ ] Here Subset-036 is meant.
ADD:
Linking Information. Linking Information is added to the linking array starting from index 0 without gaps.
The Standard says: The criteria for data consistency of track messages is defined in SUBSET-026-3.16.1.1
- whole message shall be complete in respect to the ETCS language
- variables shall not have invalid values
- message shall be received in due time
- the message shall be received at the right expected location
Finding:
- [ ] Of the claimed 4 aspects only parts of the first aspect have been covered in the detailed description below.
- [ ] Detailed aspects to which parts of the ETCS language completeness check is covered is needed here.
ADD: `Telegrams received as invalid are passed to the “Check-Function” to process errors in communication with the track side according to the requirements and in a single place.
...
Subset-026, Chapter 3.16.2: Check of the balise group `
The Standard says: Subset-026-3.16.2.1.3 states that a balise within a balise group shall be regarded as missed if
- not found within the maximum distance
- following balise in group has been passed
Finding:
- [ ] The function does not seem to do any analysis according to missing parts in a group. Are these information added at a later part?
ADD:
Subset-026, Chapter 4.5.2 Active Functions Table
Finding:
- [ ] Please, give a reference in the text in which way this part is covered.
Within the design working package (WP3) the Funcitonal Requirement Specificaiton is defined by User Stories. These User Stories are based on the application at the Amsterdam - Utrecht ETCS L2 track. Receive Trackside Message receives the input information from BTM and Radio and build the message, which is afterwards checked for use in the EVC. For Radio this is mainly consists of creating the internal data structure needed. For BTM information the balise telegrams are combined to a complete BG message.
Related to issue #237
assigned to @janWelte