search

openEXO / cloud-kepler

Cloud Kepler is a cloud enabled Kepler Planet searching pipeline
8 stars 3 forks source link

Fix unit test #23

Closed scfleming closed 10 years ago

scfleming commented 10 years ago

Unit test now does correct comparison between the closest segment "event" (based on timestamp) and the expected transit parameters from the model. Note that in both test_bls_pulse and test_bls_pulse_vec some transit events are failing due to timestamp and/or durations not being close enough to expected values.

zonca commented 10 years ago

I think it would be useful to print out some details when a test is failing, so it is possible to have a little insight also on travis-ci before running locally. If you push other commits on your branch, the PR is automatically updated and Travis runs again.

scfleming commented 10 years ago

Most recent commit adds diagnostic information to a test failure (expected value, observed value, tolerance, etc.) @zonca please review and merge when ready.

zonca commented 10 years ago

ok @scfleming I am merging this, we need to focus on #25 to fix the tests