search

openFrameworks-RaspberryPi / openFrameworks

This repo has migrated into the openFramworks core! Please go to http://github.com/openFrameworks/openFrameworks for the latest!
http://github.com/openFrameworks/openFrameworks
Other
104 stars 11 forks source link

APPNAME_SUFFIX in config.make being ignored #126

Closed jvcleave closed 11 years ago

jvcleave commented 11 years ago

the config.make files in the openFrameworks/scripts/linux/template/linux* folders have an option for a APPNAME_SUFFIX to be used to optionally append a file extension to compiled apps - however but it is not implemented in the new Makefile system

I know @arturoc removed the previous implementation of appending extensions https://github.com/openFrameworks-RaspberryPi/openFrameworks/issues/105 but I don't recall seeing APPNAME_SUFFIX before

bakercp commented 11 years ago

@jvcleave is this still an issue?

jvcleave commented 11 years ago

Yes, enabling APPNAME_SUFFIX in config.make doesn't append anything

arturoc commented 11 years ago

yes, i disabled APPNAME_SUFFIX since it's always the same in windows (.exe) and none in the rest of the platforms (.app in osx is not for the binary but for the folder of the bundle) so by now there's no suffix and if we do windows we can just set it by default.

if it's in the config.make we should remove that variable from there. i can do it in the new makefiles branch before merging into develop

arturoc commented 11 years ago

just fixed this in the PR and merged it into develop!!