search

openFyde / overlay-orangepi5-openfyde

openFyde supported hardware Orange Pi 5 build artefacts and pre-built image releases.
BSD 3-Clause "New" or "Revised" License
69 stars 5 forks source link

Proposal for r108 script #6

Closed chinen95 closed 1 year ago

chinen95 commented 1 year ago

Thank you for your work! The shell used in r108 script is #!/bin/sh, but the code was writen for bash. When running on Ubuntu with default settings, the following error will be reported: ./orangepi5-openfyde-r108.run --boot sata ./orangepi5-openfyde-r108.run: 53: [: sata: unexpected operator ./orangepi5-openfyde-r108.run: 56: [: sata: unexpected operator --boot requires an argument Because the /bin/sh is linked to dash in ubuntu by default. Is it better to change it to #!/bin/bash to make it less likely that errors will occur?

Damenly commented 1 year ago

Oh.. Indeed. Fixed and release image was updated. It also fixes badness in MacOS because its echo of /bin/sh doesn't support -n.

chinen95 commented 1 year ago

Thank you for fixing the issue quickly!