search

openHPI / codeharbor

Exchange of Programming Exercises acrossdiverse Code Assessment Systems through CodeHarbor
BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

1094 select proforma version for export direct download api #1550

Closed kkoehn closed 1 week ago

kkoehn commented 1 month ago

depends on https://github.com/openHPI/proformaxml/pull/409

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.14%. Comparing base (138864c) to head (6b829d6). Report is 8 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1550 +/- ## ======================================= Coverage 94.13% 94.14% ======================================= Files 123 123 Lines 3000 3004 +4 ======================================= + Hits 2824 2828 +4 Misses 176 176 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kkoehn commented 1 month ago

@MrSerth thanks for the feedback, I fixed your suggestions. I'm still waiting to merge the proforma PR, so we can also fix those edge-cases.

MrSerth commented 2 weeks ago

Since https://github.com/openHPI/proformaxml/pull/409 was merged, we can now draft a new ProFormA version, update this PR and undraft it.

kkoehn commented 2 weeks ago

@MrSerth Do you think we need to address the case of more ProformaXML version being added? Currently it is assumed that every saved task has the latest version. If a new version gets added that could lead to problems. A possible solution could be to add a proforma_version column on task. What do you think?