search

openHPI / codeharbor

Exchange of Programming Exercises acrossdiverse Code Assessment Systems through CodeHarbor
BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

Add missing SolidQueue migration and prevent further occurrences #1586

Closed MrSerth closed 3 weeks ago

MrSerth commented 3 weeks ago

With #1584, Dependabot bumped SolidQueue from 0.4.1 to 0.5.0. The new version of SolidQueue, however, requires a database migration that wasn't applied.

Therefore, this PR adds two commits:

  1. We fix the underlying issue and let the CI fail if SolidQueue ships with a migration not yet applied (db9739e6).
  2. We add the missing migration and the updated schema (cddd453b).

As you can see from the GitHub CI status, the first commit (db9739e6) is working as expected and recognizing a potential issue: Pipeline failure due to a PendingMigrationError. With these changes, I would assume the same bug doesn't occur another time.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.83%. Comparing base (992aeab) to head (cddd453). Report is 7 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1586 +/- ## ======================================= Coverage 93.83% 93.83% ======================================= Files 123 123 Lines 2985 2985 ======================================= Hits 2801 2801 Misses 184 184 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.