openHPI / codeocean

CodeOcean is an automated assessment tool for web-based coding exercises
BSD 3-Clause "New" or "Revised" License
64 stars 27 forks source link

Release runner in case of errors #2520

Closed MrSerth closed 2 weeks ago

MrSerth commented 1 month ago

Previously, a runner was not released in case of an Runner::Error. Especially when a runner was not found (i.e., when executing an arbitrary command), a Runner::Error::RunnerNotFound exception was thrown. Then, the automatic request for a new runner failed, since the previous runner was still in use.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.40%. Comparing base (bebfa9d) to head (91fc7fb). Report is 48 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2520 +/- ## ========================================== + Coverage 69.37% 69.40% +0.03% ========================================== Files 199 199 Lines 6347 6347 ========================================== + Hits 4403 4405 +2 + Misses 1944 1942 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.