openHPI / codeocean

CodeOcean is an automated assessment tool for web-based coding exercises
BSD 3-Clause "New" or "Revised" License
64 stars 27 forks source link

Add Solid Queue backend for Active Job #2526

Closed MrSerth closed 1 week ago

MrSerth commented 1 month ago

With these changes, we introduce a dedicated job backend for CodeOcean and migrate away from the default :async backend. This will improve reliability and allow for future introduction of developer-defined jobs. For now, the backend is mainly used for library-defined jobs.

This PR assumes that the following PR is merged first:

However, since the PR linked is mainly about documentation, this is not a show-stopper.

MrSerth commented 2 weeks ago

What's the difference between developer-defined jobs and library-defined jobs in the CodeOcean context? Is this Solid Queue wording? 🤔

I chose this wording myself and would define the terms as follows:

Seems like I have to read more about Solid Queue soonish. 😇

Yes, that's definitely recommended! Solid Queue is now a default with Rails 8, so feel free to read more about it :+1.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.53%. Comparing base (80b2ae6) to head (7d3e17f). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
app/jobs/concerns/active_record_logging.rb 50.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2526 +/- ## ========================================== - Coverage 69.54% 69.53% -0.01% ========================================== Files 200 202 +2 Lines 6350 6362 +12 ========================================== + Hits 4416 4424 +8 - Misses 1934 1938 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.