search

openHPI / codeocean

CodeOcean is an automated assessment tool for web-based coding exercises
BSD 3-Clause "New" or "Revised" License
64 stars 27 forks source link

Selenium: Refactor WaitFor* scripts to prevent crashes #2591

Open MrSerth opened 2 days ago

MrSerth commented 2 days ago

The previously used approach with Timeout.timeout works. However, it might interrupt the page.evaluate_script, which will cause an unhandled exception with the Selenium webdriver which in turn crashes. Once crashed, all further Selenium-based tests will fail, too.

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.53%. Comparing base (e9a4123) to head (dac8f6c). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2591 +/- ## ======================================= Coverage 69.53% 69.53% ======================================= Files 202 202 Lines 6372 6372 ======================================= Hits 4431 4431 Misses 1941 1941 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.