search

openHPI / xikolo-android

📱 Android App of the HPI MOOC Platform
https://play.google.com/store/apps/dev?id=7185448023325736337
GNU General Public License v3.0
41 stars 15 forks source link

channel teaser video implemented #195

Closed SanJSp closed 4 years ago

SanJSp commented 4 years ago

This is a first solution for the Channel Teaser Video Issue #190

The collabsing toolbar is only shown, if there is no Channel Teaser Video. If there is one, the Video will be embedded as meta object in the Meta Section List and the collapsing toolbar is locked.

~Currently there ist still one major bug:~

~When the ChannelDetailsFragment is opened and one clicks on the channel, the Video is not shown. It is as if there was no test for the stageStream, so the collapsing toolbar is shown. When you reopen the channel the video is shown. Unfortunately the same problem appears when you dont have a teaser video, so a Channel without a stageStream would still lock the toolbar and show the Video Layout. I (and Ben) have not been able to find a solution for that.~

Furthermore I'm looking forward to UI feedback. Here is what it looks like:

You see two play buttons, because openSAP embedded a play button on the thumbnail.

bengelhaupt commented 4 years ago

I was able to fix the issue. The problem was that in the ChannelDetailsActivity, no network request was made, so the unmanaged database entry had been used which might not yet have a stageStream set. For this, I had to create the CollapsingToolbarViewModelActivity which is the CollapsingToolbarActivity inheriting from ViewModelActivity instead of BaseActivity. There was also a bit of white space around the video, caused by the RecyclerView padding. I introduced a somewhat messy but short workaround to fix this by applying negative margin on the video.