search

openHPI / xikolo-android

📱 Android App of the HPI MOOC Platform
https://play.google.com/store/apps/dev?id=7185448023325736337
GNU General Public License v3.0
41 stars 15 forks source link

Hide proctored items #223

Closed bengelhaupt closed 4 years ago

bengelhaupt commented 4 years ago

When an Item is proctored, the ProctoredItemFragment is inflated into the ViewPager right away. Is checking item.proctored == true enough? All this Fragment does is showing the warning

Nicht verfügbar Dieser Inhalt ist auf Mobilgeräten nicht verfügbar, da ein qualifiziertes Zertifikat gebucht wurde. Bitte nutzen Sie einen Computer, um auf den Inhalt zuzugreifen.

Not available This item can't be accessed on mobile because you booked a qualified certificate. Please use a computer to access it.

I tested the Fragment itself by mocking the check but wasn't able to test the actual check because I don't have a proctored course at hand.

Fixes #217

tobiasrohloff commented 4 years ago

The general approach looks good to me. However, you need to check the enrollment as well if the proctoring was booked for that course by the user.

bengelhaupt commented 4 years ago

I added the enrollment check

tobiasrohloff commented 4 years ago

Thanks!