search

openHPI / xikolo-android

📱 Android App of the HPI MOOC Platform
https://play.google.com/store/apps/dev?id=7185448023325736337
GNU General Public License v3.0
41 stars 15 forks source link

Add jump-off points for additional external pages #225

Closed bengelhaupt closed 4 years ago

bengelhaupt commented 4 years ago

Just like in picture 3 of #207. Enabled only for openSAP.

Fixes #207

tobiasrohloff commented 4 years ago

Since this a openSAP-only feature I would like to keep as much code as possible in the corresponding build folder opensap. Do you think it is possible to move it there?

tobiasrohloff commented 4 years ago

Okay, Kommando zurück. Podcasts are coming for openHPI as well. So let's build this as a generic "external links" feature for the navigation drawer. Maybe we can keep this out of the Config and use brand-specific string array resources instead?

bengelhaupt commented 4 years ago

Yeah, can do that. I would implement it somewhat as a per-flavor R.menu.navigation. So the url's should be placed in the resources instead of the Config? Will the podcasts url of openHPI be https://open.hpi.de/podcasts?

tobiasrohloff commented 4 years ago

Right now it is https://open.hpi.de/pages/podcast. Yes, I would like to put that into the resources. I'll probably refactor all the legal links in the same way.

bengelhaupt commented 4 years ago

I did not go with a per-flavor navigation menu resource because it is a generic feature and the check whether it is supported when setting the url has to be done either way, so I just change the visibility of the items (or the whole group when none are supported).