search

openHPI / xikolo-android

📱 Android App of the HPI MOOC Platform
https://play.google.com/store/apps/dev?id=7185448023325736337
GNU General Public License v3.0
41 stars 15 forks source link

Replace Bypass with Markwon as used markdown library #272

Closed bengelhaupt closed 4 years ago

bengelhaupt commented 4 years ago

Bypass as our markdown library was not well maintained and required some glue code to work with Glide. Markwon is well maintained and based on commonmark by Atlassian. It supports Glide and custom styling.

There are only subtle changes in styling such as bullet point size. Markwon would render an underline under headings, which I removed (to match the web). Is there a xikolo markdown reference to compare our rendered content to the web rendered?

Probably Fixes #264 Fixes #266 Fixes #267

(I also added a larger padding to the bottom of the course description to better support devices with rounded edges)

tobiasrohloff commented 4 years ago

Cool stuff. We don't really have a markdown reference, but this item has a lot of examples. But it is not bad if everything does not look the same.

PS: Please assign tickets you're working on to yourself, so nobody else will start with these as well.

bengelhaupt commented 4 years ago

tobiasrohloff commented 4 years ago

Looks nice! I checked the available plugins and I would probably include more of them to provide the best compatibility:

implementation "io.noties.markwon:core:$markwon_version"
implementation "io.noties.markwon:ext-latex:$markwon_version"
implementation "io.noties.markwon:ext-strikethrough:$markwon_version"
implementation "io.noties.markwon:ext-tables:$markwon_version"
implementation "io.noties.markwon:ext-tasklist:$markwon_version"
implementation "io.noties.markwon:html:$markwon_version"
implementation "io.noties.markwon:image:$markwon_version"
implementation "io.noties.markwon:image-glide:$markwon_version"

What do you think?

bengelhaupt commented 4 years ago

Looks nice! I checked the available plugins and I would probably include more of them to provide the best compatibility:

implementation "io.noties.markwon:core:$markwon_version"
implementation "io.noties.markwon:ext-latex:$markwon_version"
implementation "io.noties.markwon:ext-strikethrough:$markwon_version"
implementation "io.noties.markwon:ext-tables:$markwon_version"
implementation "io.noties.markwon:ext-tasklist:$markwon_version"
implementation "io.noties.markwon:html:$markwon_version"
implementation "io.noties.markwon:image:$markwon_version"
implementation "io.noties.markwon:image-glide:$markwon_version"

What do you think?

Sounds good. I added all of them except image, because we already have image-glide.