search

openHPI / xikolo-ios

📱 iOS App of the HPI MOOC Platform
https://itunes.apple.com/us/developer/hasso-plattner-institut/id440210904
GNU General Public License v3.0
51 stars 11 forks source link

Add scroll view to login or hide keyboard #63

Closed bjrne closed 6 years ago

bjrne commented 8 years ago

On small screens, you can't see the register or even login button.

janrenz commented 8 years ago

We could also make the icon smaller, and the icon should be build specific

janrenz commented 7 years ago

Wasn't this fixed?

mathebox commented 7 years ago

This should be check for small iPhones (SE, 5s, ...) and also iPads (espacially Landscape orientation)

mathebox commented 7 years ago

I think we won't need a scroll view for this. Just modify the autolayout constraints.

bjrne commented 7 years ago

The problem is when the keyboard comes up, but yeah, we can also try new constraints.

mathebox commented 7 years ago

Here it worked pretty well: https://github.com/schul-cloud/schulcloud-mobile-ios/commit/95376d6a5f5b7dc72607e5c783abf8305a470efe#diff-6007bd9fe1c21c13837a2dfe38f9a43aR72

We don't need to show the register and sso buttons when the keyboard is shown. But we should add a tap gesture recognizer to dismiss the keyboard when the user taps outside of the login button or the input elements.