search

openLRSng / openLRSng-configurator

Chromium / Google chrome based configurator for openLRSng firmware
GNU General Public License v3.0
17 stars 32 forks source link

Backup doesn't support manually entered hop channels #15

Closed waketime closed 10 years ago

waketime commented 10 years ago

Among other options, the Configurator program allows me to manually select exactly which frequencies I want to use for my hop channels. But when I select Backup All Profiles, it does not backup the frequencies I manually entered on each profile. When I restore the file, the Configurator randomly picks channels between the base and max frequency, since it did not save my manually entered frequencies.

Using the configurator spectrum analyzer, I know there are frequencies I want to avoid. Manually entering hop channels allows me to do this.

cTn-dev commented 10 years ago

i went ahead and created 3 custom profiles (with all of the using manually entered hop frequencies), all of them got saved and restored correctly (both with single profile and multiple profile backup files), are you sure that you are using backup file generated in configurator version 0.38 or higher ?

waketime commented 10 years ago

Thanks for looking into this so quickly. I am using latest versions 0.41 and 3.6.2.

I should have looked into this in more detail before I posted the issue. I just did more testing and I better understand the issue now.

It relates to the fact that the Maximum Desired Frequency parameter is not backed up & restored. 450 MHz is the highest allowed by USA Amateur Radio. Even though I use manually configured hop channels, I may at some point use the "randomize during bind" feature, so I've been setting Maximum Desired Frequency to 450000

The backup/restore process that causes my problem is this:

The last step randomizes my previously entered manual hop channel frequencies, but only on whatever profile is selected at the time I make the change from 463000 (default) to 450000.

I now see there is an effective workaround following the process below, by setting Maximum Desired Frequency before doing the restore:

Shouldn't the Maximum desired frequency parameter be included in the backup/restore code? Also the Mute buzzer?

Also, shouldn't the Maximum desired frequency and Mute buzzer parameters be specific to each of the four profiles rather than a global parameter across all four profiles?

I think it would be better if a Maximum Desired Frequency change did not trigger a randomize function as it does now.

cTn-dev commented 10 years ago

Thanks for letting me know, this is indeed bug in the configurator, i traced down the buggy (in this case missing code) and i will publish a bugfix release in couple of hours

cTn-dev commented 10 years ago

i will keep this issue open until you can verify the behavior is correct on the latest configurator release (0.42), you will have to create a new backup for the new restore routine as it needs more data

waketime commented 10 years ago

Thanks! It make take me a few days, but I'll test and reply back here.

waketime commented 10 years ago

I've successfully tested backup/restore using 0.42. Much better now and looks perfect to me. Thanks for this, and for all your efforts on the configurator. Very useful code!

cTn-dev commented 10 years ago

anytime :-)