openMF / android-client

An android client for the MifosX platform
https://openmf.github.io/mobileapps.github.io/
Mozilla Public License 2.0
193 stars 570 forks source link

Refactor: Migrate CreateNewCenterFragment to Jetpack Compose #2088

Open ashutosh-kumar-kushwaha opened 2 months ago

ashutosh-kumar-kushwaha commented 2 months ago

Fixes #2077

Please Add Screenshots If there are any UI changes.

Screenshot_20240402-214705_MifosXDroid

Screenshot_20240402-214723_MifosXDroid

Please make sure these boxes are checked before submitting your pull request - thanks!

therajanmaurya commented 2 months ago

I tested the functionality, It is not same as it was implemented in XML and also search functionality is broken. I always get no result.

ashutosh-kumar-kushwaha commented 2 months ago

I tested the functionality, It is not same as it was implemented in XML and also search functionality is broken. I always get no result.

The Create Center functionality is broken in XML as well. Always gives HTTP 400 or 500.

The progress bar was implemented inside the screen in XML, whereas I implemented it within a Dialog in Compose. I will fix that. Apart from this, I did not see any other differences.

therajanmaurya commented 2 months ago

Can you please upload the before and after videos? I want to include this implementation in our codebase but we must maintain the code quality.

Also check why always API gives No search found but in development branch it does return on searc

ashutosh-kumar-kushwaha commented 2 months ago

Can you please upload the before and after videos? I want to include this implementation in our codebase but we must maintain the code quality.

Before -

https://github.com/openMF/android-client/assets/109234707/5d62caa4-a78b-4392-9d87-8d477077764f

After -

https://github.com/openMF/android-client/assets/109234707/75d392ba-719a-4cc7-9fdc-b8b6d801b66f

Also check why always API gives No search found but in development branch it does return on searc

The SearchScreen one is a different PR. This PR is for CreateNewCenterFragment.