openMF / android-client

An android client for the MifosX platform
https://openmf.github.io/mobileapps.github.io/
Mozilla Public License 2.0
193 stars 570 forks source link

New Feature: Allow user to update server configuration #2105

Closed niyajali closed 3 weeks ago

niyajali commented 4 weeks ago

Fixes MIFOSAC-167

Please Add Screenshots If there are any UI changes.

https://github.com/openMF/android-client/assets/26448068/4693da70-2640-441e-85af-708b1ee639d1

Please make sure these boxes are checked before submitting your pull request - thanks!

niyajali commented 4 weeks ago

@therajanmaurya kindly review this PR, I haven't applied in :network module yet, this is the main internal part like the heart of our app, so I would like to discuss it with you before using it in the module, it will be better if we could join a meeting with @Aditya-gupta99 to share my thoughts properly.

therajanmaurya commented 4 weeks ago

This does not need to interact with network module. It will interact with data - datastore module datastore - It will have function to update the config data - It will expose the datastore update config function. We already have the functions

image
niyajali commented 4 weeks ago

yes sir but i think we have to configure BaseApiManager as well because in their we are using prefManager

niyajali commented 4 weeks ago

@therajanmaurya sir applied config in network module, kindly take a look