search

openMF / android-client

An android client for the MifosX platform
https://openmf.github.io/mobileapps.github.io/
Mozilla Public License 2.0
200 stars 589 forks source link

Empty toast message is displayed when the user taps the 'Save' button while there is no internet connection in the savings account approval fragment #674

Closed AbhilashG97 closed 7 years ago

AbhilashG97 commented 7 years ago

Summary:

Empty toast message is displayed when the user taps the 'Save ' button while there is no Internet connection in the savings account approval fragment. A suitable toast message stating that there is no Internet connection would be a better response.

Steps to reproduce:

Step 1) Open the app. Step 2) Tap on Clients from the navigation drawer. Step 3) Select a client. Step 4) Tap on Savings Accounts and select an account that requires to approve savings. Step 4) Tap on "Approve Savings button". Step 5) Disable Internet connection. Step 6) Tap on "Save" button.

Expected behavior:

We should see a toast message stating that there is no Internet connection.

Observed behavior:

A blank toast message is displayed.

Device and Android version:

Device : Motorola Moto G 1st Generation [XT1033] [Falcon] ROM : CyanogenMod 13.0 Snapshot build

GIF:

videotogif_2017 04 19_21 54 55

AbhilashG97 commented 7 years ago

I would like to work on this issue.

AbhilashG97 commented 7 years ago

I have made the required changes, please review my pull request and kindly let me know if I have to make any further changes. Pull request - https://github.com/openMF/android-client/pull/676

therajanmaurya commented 7 years ago

fix in #676