search

openMF / android-client

An android client for the MifosX platform
https://openmf.github.io/mobileapps.github.io/
Mozilla Public License 2.0
200 stars 589 forks source link

Empty toast message is displayed when user clicks on "Submit" button in the Create Group Fragment in the absence of Internet connection. #684

Closed AbhilashG97 closed 7 years ago

AbhilashG97 commented 7 years ago

Summary:

Empty toast message is displayed when user clicks on "Submit" button in the Create New Group Fragment. A suitable response would be to have a toast message stating that there is no Internet connection.

Steps to reproduce:

Step 1) Open the app. Step 2) Tap on the menu key in the top right corner (three dots) and tap on Create Group. Step 3) Disable Internet connection. Step 4) Tap on the "Submit" button.

Expected behavior:

A toast message stating that there is no Internet connection would be an appropriate response.

Observed behavior:

An empty toast message is displayed when the user loses Internet connection.

Device and Android version:

Device : Motorola Moto G 1st Generation [XT1033] [Falcon] ROM : CyanogenMod 13.0 Snapshot build

GIF:

videotogif_2017 05 04_21 07 28

AbhilashG97 commented 7 years ago

I would like to work on this issue.

AbhilashG97 commented 7 years ago

I have made the required changes, please let me know if I have to make any further changes. Pull request - https://github.com/openMF/android-client/pull/689