openMF / android-client

An android client for the MifosX platform
https://openmf.github.io/mobileapps.github.io/
Mozilla Public License 2.0
200 stars 589 forks source link

User is allowed to enter incorrect pass-code 4 times instead of 3 times #909

Closed AbhilashG97 closed 6 years ago

AbhilashG97 commented 6 years ago

Summary:

This is a minor issue where the user is allowed to enter incorrect pass-code 4 times instead of 3 times.

Steps to reproduce:

  1. Open the app
  2. Setup a pass-code
  3. Open the app again
  4. Enter incorrect passcode

Expected behaviour:

The app should only allow the user to enter incorrect pass-code 3 times.

Observed behaviour:

Currently, the app allows the user to enter incorrect pass-code 4 times.

Device and Android version:

Device : Xiaomi Mi A1 [tissot] ROM : Stock Android [Oreo 8.0.0]

GIF:

videotogif_2018 02 23_08 44 20

AbhilashG97 commented 6 years ago

I would like to work on this issue.

AkshGautam commented 6 years ago

@AbhilashG97 The toast message says that "You have entered incorrect Passcode more than 3 times." which makes the issue redundant since if the toast message is explicitly mentioning that the 4th attempt is considered failure not 3rd.

AbhilashG97 commented 6 years ago

@AkshGautam, you're right. I failed to notice this.

AbhilashG97 commented 6 years ago

I apologize for reporting a false issue.