openMF / community-app

This was the former default web application built on top of the Apache Fineract platform. It's now deprecated and replaced by the the Mifos X Web App (https://github.com/openMF/web-app maintained by the Mifos Initiative as a reference solution for financial inclusion. It is a Single-Page App (SPA) written in web standard technologies.
http://openmf.github.io/community-app/
Mozilla Public License 2.0
313 stars 1.02k forks source link

Reskin: Approve/Reject navbar in check inbox & tasks, Affix not working. #2091

Closed gkrishnan724 closed 7 years ago

gkrishnan724 commented 7 years ago

If we scroll down, the Approve/Reject navbar should remain below the Mifos navbar. Also, If possible change all the icons to font-awesome icons so that they can load in localhost.

New Skin: abc

Old skin: abcd

gkrishnan724 commented 7 years ago

I'm working on this :)

santoshconflux commented 7 years ago

@gkrishnan724 , Are you able to resolve this issue?

gkrishnan724 commented 7 years ago

@santoshmath I'm not able to resolve it, still looking at it. However, I don't mind if someone resolves and sends a PR

gkrishnan724 commented 7 years ago

It seems the jquery code which is supposed to make the affix is not working:

$(window).scroll(function () {
                if ($(this).scrollTop() > 100) {
                    $('.head-affix').css({
                        "position": "fixed",
                        "top": "50px"
                    });

                } else {
                    $('.head-affix').css({
                        position: 'static'
                    });
                }
            });

I also noticed that the window scroll event is not firing properly, hence I tried to replace it by angular.element($window).bind("scroll") which also did not fire properly. Another thing is, the scroll events worked on the login page but did not work when the view was loaded.

santoshconflux commented 7 years ago

@mbj36, @gkrishnan724 , is it resolvable?

mauliksoneji commented 7 years ago

@gkrishnan724 @mbj36 ,please provide a status update on this

mbj36 commented 7 years ago

@santoshmath Retest and close it

santoshconflux commented 7 years ago

Tested it on 2/6/2017 on new_reskin branch. This issue is fixed.