search

openMF / community-app

This was the former default web application built on top of the Apache Fineract platform. It's now deprecated and replaced by the the Mifos X Web App (https://github.com/openMF/web-app maintained by the Mifos Initiative as a reference solution for financial inclusion. It is a Single-Page App (SPA) written in web standard technologies.
http://openmf.github.io/community-app/
Mozilla Public License 2.0
313 stars 1.02k forks source link

Client Address Issues #2655

Open santoshconflux opened 6 years ago

santoshconflux commented 6 years ago
  1. Go to System>Configuration and enable "Enable-Address".
  2. Go to any client page and click on 'Address' tab which is next to 'General' tab.
  3. Click on Add Address. You can see there are already Address lines 1, 2 & 3 , there is no need of 'Street' field. It should be removed.
  4. Submit the address for the client.
  5. Click on 'Edit' button for the client.

    Edit button is not showing previous values entered , it should show the previous values. In stead of Edit, there should be 'Submit' button(Refer the screenshot)

clientaddress

mbj36 commented 6 years ago

GitMate.io thinks the contributor most likely able to help you is @mbj36.

yashasvi13 commented 6 years ago

@mbj36 As I understood there are 3 issues.

  1. Remove fields for street - I removed the fields from front-end but there is a server-side check for that field so should I send a placeholder value or will this be changed from server side as well? Please advise.
  2. Dropdowns are not pre-filled when editing an address. I checked the directive for this and it seems that library name chosen-jquery is being used for auto-complete + select. I'll look for the library and implement this one.
  3. Replace text of button 'Edit' to 'Submit'. (Already done) Also, there is no country dropdown in addressform.html. Is this consistent with business logic?
gkrishnan724 commented 6 years ago

Hi, @yashasvi13 looking at the issue, I believe we cannot remove the street field yet because the server-side is checking for it as you mentioned, Also Street field is mandatory. So It could be removed after the back-end implementation has been done.

I am not sure whether the dropdowns should be pre-filled, I don't really think that is necessary since the fields aren't mandatory.

About the country dropdown missing, I believe we should add that :+1:

The Edit button issue is when you edit the address. Just changing the label to submit should be fine.

yashasvi13 commented 6 years ago

Hi @mbj36 @gkrishnan724 It seems that the standard way of making a field visible/hiding it in front-end is implemented on server-side, like this endpoint https://demo.openmf.org/fineract-provider/api/v1/fieldconfiguration/ADDRESS . So will this be taken from the server side as well?