search

openMF / community-app

This was the former default web application built on top of the Apache Fineract platform. It's now deprecated and replaced by the the Mifos X Web App (https://github.com/openMF/web-app maintained by the Mifos Initiative as a reference solution for financial inclusion. It is a Single-Page App (SPA) written in web standard technologies.
http://openmf.github.io/community-app/
Mozilla Public License 2.0
313 stars 1.02k forks source link

Adding 'Specific Due Date' charge to the loan account when date is not given, is not throwing any validation #2658

Closed santoshconflux closed 4 years ago

santoshconflux commented 6 years ago
  1. Create a loan Account for a client.
  2. Create a specific due date charge.
  3. In Loan account, click on 'Add charge' and select specific due date charge, but don't give date and try to submit it.

'Due date is mandatory field but application is accepting null value for it'

Check the screenshot:

duedate

AgnessMeena commented 6 years ago

Hi @santoshmath , I updated my code, i see it works fine in develop branch.. see a screen-shot.. adding Or ,, Can you take a look? and correct me

abhaychawla commented 5 years ago

@santoshconflux @ShruthiRajaram @gkrishnan724 I think the issue is no longer reproducible. I tested on the demo server and got a validation error. Can you please check and close this? This is also present as a GCI task and a student tried to attempt it here but was unable to reproduce it as well: https://codein.withgoogle.com/dashboard/task-instances/5266254341341184/

gkrishnan724 commented 5 years ago

@abhaychawla @santoshmath, I believe the error exists. I tried submitting it for the same loan account and charge as given in santosh's screenshot i.e : https://staging.openmf.org/#/addloancharge/50 and select the charge as sew when you hit submit without giving the date. It gives an internal server error.

This is the response if you see it in the network tab: {"timestamp":1544418611664,"status":500,"error":"Internal Server Error","exception":"java.lang.NullPointerException","message":null} I believe this is a server side error.

ShruthiRajaram commented 5 years ago

Issue is fixed . Closing the issue

ShruthiRajaram commented 5 years ago

@gkrishnan724 agreed. @santoshconflux it is a null pointer exception, so kindly create an issue in Fineract Jira as well.

Due date is a mandatory field and it is not handled properly in front end. It is allowing null as well. So @abhaychawla I too believe this should be fixed in community-app. So for this issue, making due-date go through mandatory check(not just the asterisk symbol) should be added. Correct me if I am wrong.

santoshconflux commented 5 years ago

@ShruthiRajaram , sure

abhaychawla commented 5 years ago

Yes, I agree with you. @ShruthiRajaram @gkrishnan724 But I am not sure why when I tried it here I didn't get a null pointer exception just this error:

screenshot 362

santoshconflux commented 5 years ago

Fineract side ticket: https://issues.apache.org/jira/browse/FINERACT-671