openMF / community-app

This was the former default web application built on top of the Apache Fineract platform. It's now deprecated and replaced by the the Mifos X Web App (https://github.com/openMF/web-app maintained by the Mifos Initiative as a reference solution for financial inclusion. It is a Single-Page App (SPA) written in web standard technologies.
http://openmf.github.io/community-app/
Mozilla Public License 2.0
313 stars 1.02k forks source link

Future joining dates possible while creating employee #2859

Closed sarthak-sehgal closed 6 years ago

sarthak-sehgal commented 6 years ago

Description

In the "Joined on" section which is mandatory to be filled while creating an employee, future dates are disabled on the calendar which pops up but can be manually types and are successfully validated.

Steps to Reproduce

Mifos Menu Bar >> Admin >> Organization >> Manage Employees >> Create Employee >> Enter all the required fields >> In the joining date, enter a future date manually (e.g.: "20 December 2060") >> Submit

Expected Behaviour

An error message should appear saying that the "Joined date" must be a date on or before that day.

Actual Behaviour

The employee is created successfully.

Settings

Screenshots, if any

screenshot from 2018-01-28 01 22 53 screenshot from 2018-01-28 01 22 55 screenshot from 2018-01-28 01 23 01

ankit01ojha commented 6 years ago

@sarthak-sehgal , This issue might be present in other places also, it would be nice if you could create a parent issue for missing validations when restricted dates are entered (I found one in ManageOffices).

sarthak-sehgal commented 6 years ago

@ankit01ojha, thanks for the info. I'll check at other places too (where the same input field validation has been used) and then create a parent issue soon.

sarthak-sehgal commented 6 years ago

Parent issue #2893 has been created. Hence, closing.