search

openMF / community-app

This was the former default web application built on top of the Apache Fineract platform. It's now deprecated and replaced by the the Mifos X Web App (https://github.com/openMF/web-app maintained by the Mifos Initiative as a reference solution for financial inclusion. It is a Single-Page App (SPA) written in web standard technologies.
http://openmf.github.io/community-app/
Mozilla Public License 2.0
313 stars 1.02k forks source link

Tax field Edit/Add option not available on the Edit charge #3337

Closed bharathcgowda closed 3 years ago

bharathcgowda commented 3 years ago

when you try to add a new tax group to the existing charge, the tax mapping field is disabled currently

steps to reproduce

  1. create a tax group
  2. create a loan charge (without tax mapping)
  3. edit the charge and try to add the tax group ( it doesn't allow to map as the field is disabled)

expected behaviour, the system should allow changing the tax group on charge edits.

In practical scenarios, there would a requirement of changing the tax group or adding the tax group to the existing charge, for which we have to enable users to add/modify tax group during charge edit.

refer screenshot image

sankha555 commented 3 years ago

@bharathcgowda may I please take this up?

bharathcgowda commented 3 years ago

Hi, Yes you can, Thank you @sankha555

BLasan commented 3 years ago

@sankha555 Are you working on this?

sankha555 commented 3 years ago

Hey @BLasan , yep I am still working on it and have made some changes to the code. But I am not able to test it since the login isnt working for me, could you please help me out with the login. It would be great help.

image

As can be seen here, the fineract uri returns that the server could not be found. The demo.mifos.io uri doesn't validate the credentials given in the docs. It is thus not being possible for me to login and test my changes. I have also tried other methods suggested by people on the repo and on the gitter channel but didn't work. Could you please help me in this regard to login successfully. @bharathcgowda ccing this to you if you could please help me and I could then complete the patch. Thanks in advance!

BLasan commented 3 years ago

Hey @BLasan , yep I am still working on it and have made some changes to the code. But I am not able to test it since the login isnt working for me, could you please help me out with the login. It would be great help.

image

As can be seen here, the fineract uri returns that the server could not be found. The demo.mifos.io uri doesn't validate the credentials given in the docs. It is thus not being possible for me to login and test my changes. I have also tried other methods suggested by people on the repo and on the gitter channel but didn't work. Could you please help me in this regard to login successfully. @bharathcgowda ccing this to you if you could please help me and I could then complete the patch. Thanks in advance!

There's an issue with the login. I have already opened an issue for that. I'll try to get a response from @bharathcgowda sir as soon as possible regarding this issue.

bharathcgowda commented 3 years ago

Hello Team,

From the screenshot below, it looks like the front end is running locally and trying to connect to fineract.dev server. which gives me the feeling that the issue may not be because of the community app and you are not connecting to the right server.

the correct server is https://openmf.github.io/community-app/?baseApiUrl=https%3A%2F%2Fdemo.fineract.dev&tenantIdentifier=default#/

which is not yet working because of credentials not being reset yet.

dev.mifos.io Instance may have some infra issues, have informed the respective team to look into it

Meanwhile, my suggestion is you can run the server locally and test it.

Regards, Bharath Lead Implementation Analyst | Mifos Initiative Skype: live:cbharath4| Mobile: +91.7019635592 http://mifos.org http://facebook.com/mifos http://www.twitter.com/mifos

On Sat, Jan 23, 2021 at 11:07 AM Benura Abeywardena < notifications@github.com> wrote:

Hey @BLasan https://github.com/BLasan , yep I am still working on it and have made some changes to the code. But I am not able to test it since the login isnt working for me, could you please help me out with the login. It would be great help.

[image: image] https://user-images.githubusercontent.com/54751139/105569628-2f36c580-5d69-11eb-8541-179770d2dbdd.png

As can be seen here, the fineract uri returns that the server could not be found. The demo.mifos.io uri doesn't validate the credentials given in the docs. It is thus not being possible for me to login and test my changes. I have also tried other methods suggested by people on the repo and on the gitter channel but didn't work. Could you please help me in this regard to login successfully. @bharathcgowda https://github.com/bharathcgowda ccing this to you if you could please help me and I could then complete the patch. Thanks in advance!

There's an issue with the login. I have already opened an issue for that. I'll try to get a response from @bharathcgowda https://github.com/bharathcgowda sir as soon as possible regarding this issue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openMF/community-app/issues/3337#issuecomment-765871472, or unsubscribe https://github.com/notifications/unsubscribe-auth/APXFWFLYO4X3XYS2LTFEFB3S3JOADANCNFSM4WA4YWOA .

sankha555 commented 3 years ago

@bharathcgowda Thanks a lot for the update. Also, could you please instruct me as to how I can login to the dashboard while testing it locally? Do I need to create a new user or are there some other procedures to be followed? Thanks!

BLasan commented 3 years ago

@bharathcgowda Thanks a lot for the update. Also, could you please instruct me as to how I can login to the dashboard while testing it locally? Do I need to create a new user or are there some other procedures to be followed? Thanks!

I think you could use the default credentials for logging. mifos:password. Please re-correct this if I'm wrong @bharathcgowda

BLasan commented 3 years ago

If you are not working on this @sankha555 can I take up this issue ? @bharathcgowda

bharathcgowda commented 3 years ago

Yes you can :) @BLasan

BLasan commented 3 years ago

Yes you can :) @BLasan

Will start fixing this tomorrow :)

BLasan commented 3 years ago

@edcable Sir, I think we can close this issue once @bharathcgowda sir or @spider0061 reviewed and approved the PR. (No drastic changes were added)