search

openMF / digital-bank-ui

Digital Bank user interface for staff on top of Fineract CN
Mozilla Public License 2.0
18 stars 28 forks source link

Refactor all modules #36

Open abhi40308 opened 4 years ago

abhi40308 commented 4 years ago

Bug report

Currently, a lot of code can be refactored to be made in-par with coding best practices.

Refactoring pr's can be sent referencing this issue.

giorgiozoppi commented 4 years ago

We also need tslinting all the code and pass throu sonarcloud.io

On Sat, 29 Aug 2020, 14:55 Abhijeet Singh, notifications@github.com wrote:

Bug report

Currently, a lot of code can be refactored to be made in-par with coding best practices.

  • Table (ng2-smart-table) code and pager code can be moved in the common module.
  • Rxjs / observable code contains lots of places where we might not need observables, check out this https://indepth.dev/rxjs-in-angular-when-to-subscribe-rarely/ coding style guideline for reference.
  • State can be used more efficiently.

Refactoring pr's can be sent referencing this issue.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openMF/digital-bank-ui/issues/36, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGPXNMURFZL5YD7HPY4XQN3SDD3DZANCNFSM4QO7JVHA .