openMF / digital-bank-ui

Digital Bank user interface for staff on top of Fineract CN
Mozilla Public License 2.0
18 stars 28 forks source link

fix: remove deprecated node-sass and `/deep/` style selector #98

Closed abhi40308 closed 1 year ago

abhi40308 commented 1 year ago

Description

This pr:

  1. Replaces the deprecated node-sass with dart-sass. This was causing errors while building the project.
  2. Updates the package-lock.json to lockfile v2
  3. Removes the deprecated /deep/ css selector. It is not encouraged to be used anymore, due to this mechanism for piercing the style isolation sandbox around a component can potentially encourage bad styling practices.
Screenshots or link to CodePen/Plunker/JSfiddle

Am able to build the project after these changes.

Screenshot 2023-03-11 at 9 16 37 AM