openMF / fineract-pentaho

Pentaho Reporting Plugin for Apache Fineract
Mozilla Public License 2.0
26 stars 45 forks source link

Build fails with "attempting to assign weaker access privileges; was public" Could not open the public key ring #12

Closed ruprai closed 3 years ago

ruprai commented 3 years ago

Trying to build fineract-pentaho results in a failed build:


./gradlew distZip

> Task :compileJava FAILED
/home/develop/fineract-pentaho/src/main/java/org/apache/fineract/infrastructure/report/service/PentahoReportingProcessServiceImpl.java:193: error: getReportParams(MultivaluedMap<String,String>) in PentahoReportingProcessServiceImpl cannot implement getReportParams(MultivaluedMap<String,String>) in ReportingProcessService
    private Map<String, String> getReportParams(final MultivaluedMap<String, String> queryParams) {
                                ^
  attempting to assign weaker access privileges; was public
1 error

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 1s
1 actionable task: 1 executed```
ruprai commented 3 years ago

Changed private Map<String, String> getReportParams(final MultivaluedMap<String, String> queryParams) to public Map<String, String> getReportParams(final MultivaluedMap<String, String> queryParams)

francisguchie commented 3 years ago

@ruprai @vorburger got advise from Rahul to change private Map<String, String> getReportParams(final MultivaluedMap<String, String> queryParams) to public Map<String, String> getReportParams(final MultivaluedMap<String, String> queryParams)

line 193 in file PentahoReportingProcessServiceImpl.java

francisguchie commented 3 years ago

$ ./gradlew distZip

BUILD SUCCESSFUL in 13s 3 actionable tasks: 3 executed

francisguchie commented 3 years ago

@vorburger I think this issue can be closed its sorted (for me on Windows and Ubuntu 18.04)

krunal-wowoni commented 3 years ago

Hello @francisguchie ,

I have raised a issue few days back (link for raised issue: https://github.com/vorburger/fineract-pentaho/issues/13) Could you please help me to sort it out.

Thanks in advanced.

francisguchie commented 3 years ago

@krunal-wowoni

Please see below

Change private Map<String, String> getReportParams(final MultivaluedMap<String, String> queryParams) to public Map<String, String> getReportParams(final MultivaluedMap<String, String> queryParams)

line 193 in file PentahoReportingProcessServiceImpl.java

krunal-wowoni commented 3 years ago

@francisguchie

I did that changes as well.

But got the same error.

Please help me to solve this issue.

francisguchie commented 3 years ago

@krunal-wowoni please look at issue #4 i believe it is the same problem which @vorburger solved with this fix https://github.com/vorburger/fineract-pentaho/commit/2f207e50721b5e63a472f0ea382732abf802468d

You will need to make sure you have the latest build on your local repo and follow the instructions as show here below

git clone https://github.com/apache/fineract.git cd fineract && ./gradlew bootJar && cd ..

git clone https://github.com/vorburger/fineract-pentaho.git cd fineract-pentaho && ./gradlew distZip && cd ..

mkdir -p ~/.mifosx/pentahoReports/ cp ./fineract-pentaho/pentahoReports/* ~/.mifosx/pentahoReports/

./fineract-pentaho/run

These steps work well on a linux Ubuntu 16 and above

francisguchie commented 3 years ago

@krunal-wowoni
I tried the same steps on a windows 10 PC and it build well too.

may be use my repo since i have made the changes effected on a branch called PUBLICgetReportParams

https://github.com/francisguchie/fineract-pentaho/tree/PUBLICgetReportParams

hubdestro commented 1 year ago

I have tried all above steps and i am still getting same error, I am using mac and JAVA 17.0.2.