openMF / fineract-pentaho

Pentaho Reporting Plugin for Apache Fineract
Mozilla Public License 2.0
26 stars 45 forks source link

Is it possible to implement fineract-pentaho with the latest fineract-provider (1.4.0) branch ? #18

Closed sathishnr98 closed 2 years ago

sathishnr98 commented 3 years ago

Hello @vorburger and @francisguchie ,

I tried to implement fineract-pentaho with the latest fineract-provider (1.4.0) branch, as I know to implement the things in develop branch but for my convinence I need to implement this things in 1.4.0.

Is it possible to do so, then I'm just trying to do this thing and I got some errors which I have mentioned the errors what are all the things which I have faced right now,

While hitting this endpoint, Request URL: https://localhost:8443/fineract-provider/api/v1/runreports/Client%20Listing(Pentaho)?output-type=PDF&tenantIdentifier=default&locale=en&dateFormat=dd%20MMMM%20yyyy&R_selectOffice=1

WhatsApp Image 2021-03-30 at 11 46 46 AM

I got this error,

{
"developerMessage":"The request was invalid. This typically will happen due to validation errors which are provided.",
"httpStatusCode":"400",
"defaultUserMessage":"Unexpected SQL Commands found",
"userMessageGlobalisationCode":"error.msg.found.sql.injection"
}

WhatsApp Image 2021-03-30 at 11 47 32 AM

This is my tomcat log for your convenience, WhatsApp Image 2021-03-30 at 11 45 50 AM (1)

Please let me know whether there are any possible solutions to resolve the issue, if possible then could you please help me to resolve it.

francisguchie commented 3 years ago

@sathishnr98

the SQL injection is something that has been solved with the latest build. is details are explained https://github.com/apache/fineract/pull/1671

in my view if you use an build other than the latest or a release before https://github.com/apache/fineract/pull/1671 was merged, you are likely to be faced with sql-injection issues

francisguchie commented 3 years ago

@sathishnr98

I would suggest that you do a cherry-pick of the changes made in https://github.com/apache/fineract/pull/1671 and rebuild

vorburger commented 3 years ago

Hello! Thank You so much for the interest in this project. Please read #25 for an announcement re. future maintenance of this repo.

bharathcgowda commented 3 years ago

@sathishnr98 you could cherry-pick as suggested by @francisguchie or you could get the latest Fineract build 1.5 which has the fix for the issue.

francisguchie commented 2 years ago

@sathishnr98 , Would you mind closing this issue since it is solved