search

openMF / fineract-pentaho

Pentaho Reporting Plugin for Apache Fineract
Mozilla Public License 2.0
26 stars 42 forks source link

./run script doesn't work on Windows #2

Closed vorburger closed 3 years ago

vorburger commented 3 years ago

Bharat in today's comment on https://issues.apache.org/jira/browse/FINERACT-1127 raised that the current ./run script doesn't work on Windows.

The goal of this issue is to address that, probably by entirely ditch run all together, and documenting something based on https://issues.apache.org/jira/browse/FINERACT-1177.

vorburger commented 3 years ago

https://issues.apache.org/jira/browse/FINERACT-1177 just got merged. I'll therefore work on this issue "soon" (whenever I have the time).

@francisguchie @bharathcgowda et al FYI.

francisguchie commented 3 years ago

@vorburger i am eagerly awaiting

vorburger commented 3 years ago

@francisguchie @bharathcgowda check out how the README and run scripts is now... perhaps one of you would like to contribute a run.bat Windows version? (I don't have Windows.) It should hopefully be easy to create an equivalent run.bat script for Windows users, if you just look at the run Linux script, and read the new more detailed README... does that help?

francisguchie commented 3 years ago

@vorburger

I hope to look into this this coming week . Me to of late I have been moving away from Windows - more into Linux Ubuntu but i dont mind coming up with something for review (after testing it on my windows pc)

bharathcgowda commented 3 years ago

Thank you @vorburger, I will explore and get back, mostly by this weekend.

bharathcgowda commented 3 years ago

Hi, @vorburger I have created a run script for windows and have tested in my machine. Thank you for this solution :) Please do let me know if there are any changes to be made, I'll be able to correct and resend it.

https://github.com/vorburger/fineract-pentaho/pull/19

francisguchie commented 3 years ago

@bharathcgowda
I am happpy to see this - but also i need to tender in my apologies for not having made my input when i promised

vorburger commented 3 years ago

Hello! Thank You so much for the interest in this project. Please read #25 for an announcement re. future maintenance of this repo.