ph-ee: detailed instructions for ph-ee-env-template and ph-ee-env-labs

openMF / mifos-documentation

Config files, postman queries, documentation for Mifos.io lab environment

7 stars 15 forks source link

ph-ee: detailed instructions for ph-ee-env-template and ph-ee-env-labs #12

Open afk11 opened 3 years ago

afk11 commented 3 years ago

Addressed two nits above, also added another line clarifying how to host with a local docker registry

afk11 commented 2 years ago

I saw this was still open, so added another commit. Instead of the deployment script killing all kubectl instances, it will save the backgrounded instances PID and kill that

Is there anything else required for this PR @SubhamPramanik?

SubhamPramanik commented 2 years ago

LGTM

I actually don't have access to this repo to merge your PR. Usually I approve or edit changes in gitbook directly(which is linked to this repo, not sure why my access hasn't propagated to the repo), can you try sending a change request over there? I'll be able to approve it.