search

openMF / mifos-mobile-cn

Client-facing app on top of Apache Fineract CN
https://openmf.github.io/mobileapps.github.io/
Apache License 2.0
39 stars 64 forks source link

UI inconsistencies in the logout dialog box #111

Closed laxyapahuja closed 4 years ago

laxyapahuja commented 4 years ago

Summary

There are UI inconsistencies in the dialog box when logging out.

Steps to reproduce

Login -> Drawer -> Logout

Expected behaviour

The app should show a dialog box with proper margins and it should follow the Material guidelines.

Observed behaviour

A dialog box appears which has an inconsistent UI and does not follow the Material guidelines.

Device and Android Version

Android 9, Mi A3

Screenshots

rchtgpt commented 4 years ago

@laxyapahuja this issue cannot be reproduced by others simply because you have changed the AppTheme in the styles.xml from Theme.AppCompat.Light.NoActionBar to Theme.MaterialComponents.Light.NoActionBar in your local branch. Unless #110 gets merged, this issue does not make sense.

laxyapahuja commented 4 years ago

@laxyapahuja this issue cannot be reproduced by others simply because you have changed the AppTheme in the styles.xml from Theme.AppCompat.Light.NoActionBar to Theme.MaterialComponents.Light.NoActionBar in your local branch. Unless #110 gets merged, this issue does not make sense.

Thank you for pointing that out. However, I won't take this issue down because the redesign requires us to add Material AppTheme in the project. So, it's going to occur in the future. It's better if we make the app compatible with the Material theme :)

ashwinkey04 commented 4 years ago

I think it will be a good idea if this PR is labelled 'later'

rchtgpt commented 4 years ago

@laxyapahuja, now that #122 has been merged, this issue is reproducible.

laxyapahuja commented 4 years ago

@luckyman20 can be closed now.