Redesign: Customer profile activity

openMF / mifos-mobile-cn

Client-facing app on top of Apache Fineract CN

https://openmf.github.io/mobileapps.github.io/

Apache License 2.0

39 stars 64 forks source link

Redesign: Customer profile activity #112

Open rchtgpt opened 4 years ago

rchtgpt commented 4 years ago

Fixes Issue

Fixes #105

Screenshot

Screenshot (154)

Description

I have not added the bottom navigation because a lot of other activities would be involved. Hence, I believe addition of bottom navigation bar should be done in a separate PR. Would like to know the views of the project maintainers on it.

[x] Run the unit tests with ./gradlew check to make sure you didn't break anything
[x] If you have multiple commits please combine them into one commit by squashing them.

laxyapahuja commented 4 years ago

hey, I think you missed the navigation drawer icon on the top left, cause it's present in the mock-up.

luckyman20 commented 4 years ago

Try placing the camera icon around the circle image view.

rchtgpt commented 4 years ago

Try placing the camera icon around the circle image view.

@luckyman20 done :)

laxyapahuja commented 4 years ago

hey @rachittt, you'll have to add all the hex codes and dimensions in the colors.xml and dimens.xml respectively.

laxyapahuja commented 4 years ago

hey @rachittt, I think you can add the fonts now as #114 is merged.

rchtgpt commented 4 years ago

hey @rachittt, I think you can add the fonts now as #114 is merged.

before adding the fonts, I believe it is necessary to get an official approval from the admins on which font should be used for which kind of text, because it should be strictly uniform throughout the application. @luckyman20 can you please look into it ?

laxyapahuja commented 4 years ago

hey @rachittt, I think you can add the fonts now as #114 is merged.

before adding the fonts, I believe it is necessary to get an official approval from the admins on which font should be used for which kind of text, because it should be strictly uniform throughout the application. @luckyman20 can you please look into it ?

I think we should follow the same font pattern as in the mockups as that is what the mentor approved. Can you let me know what font you used for which kind of text? I've already used the fonts in my PRs. Please review them and let me know which one is wrong as I had to make some guesses because of the size of the mock-up.

garvit984 commented 4 years ago

The text color of the textbox as per the mockup is not grey. There are also some inconsistencies in comparison to original design.

rchtgpt commented 4 years ago

The text color of the textbox as per the mockup is not grey. There are also some inconsistencies in comparison to original design.

Yeah, during GCI, the project maintainers asked me to make those changes hence you will find inconsistencies in comparison to the original design in almost all redesign PRs, but I am sure those are intentional as long as they don't look aesthetically unappealing.

garvit984 commented 4 years ago

@rachittt The editext for email and mobile number in these designs asks for input on being clicked. Please correct it and also the conflicting files.