search

openMF / mifos-mobile-cn

Client-facing app on top of Apache Fineract CN
https://openmf.github.io/mobileapps.github.io/
Apache License 2.0
38 stars 64 forks source link

feat: redesign dashboard UI #118

Open laxyapahuja opened 4 years ago

laxyapahuja commented 4 years ago

Issue Fix

Fixes #102

Screenshots

Description

The addition of bottom navigation bar will be done in different PRs as discussed with a mentor.

rchtgpt commented 4 years ago

hey @laxyapahuja, I think what you have done is not correct because according to the mockups which we are currently working on, a Persistent BottomSheetDialog should be used instead of a CardView to display recent transactions. You can check the prototype video of the mockups here

laxyapahuja commented 4 years ago

hey @laxyapahuja, I think what you have done is not correct because according to the mockups which we are currently working on, a Persistent BottomSheetDialog should be used instead of a CardView to display recent transactions. You can check the prototype video of the mockups here

hey, i just checked out BottomSheetDialog and it doesn't exactly look like what is in the actual mockup. i think it'll be better if we used CardView and just add some code to drag it up. also either way, the task only mentions to "redesign" so i think the functionality can be added in another pull request.

rchtgpt commented 4 years ago

hey, i just checked out BottomSheetDialog and it doesn't exactly look like what is in the actual mockup. i think it'll be better if we used CardView and just add some code to drag it up. also either way, the task only mentions to "redesign" so i think the functionality can be added in another pull request.

The mockup which I made was actually influenced from a BottomSheetDialog and in my opinion, it is a part of design itself. @luckyman20 what do you think?

luckyman20 commented 4 years ago

@laxyapahuja You have to add this dragging functionality as this is part of frontend only.

Also, 'Direct' doesn't seems appropriate here, use 'Self' instead.

laxyapahuja commented 4 years ago

updated :D

rchtgpt commented 4 years ago

according to the mockup, you have to add a white outline to the 'Receive' button

luckyman20 commented 4 years ago

You have to shift notification bell icon too. Also, the green thing on each card is not looking good, either remove it or colour it in violet color. Do not forget to update screenshot/video recording ;)

laxyapahuja commented 4 years ago

You have to shift notification bell icon too. Also, the green thing on each card is not looking good, either remove it or colour it in violet color. Do not forget to update screenshot/video recording ;)

updated :)

rchtgpt commented 4 years ago

@laxyapahuja i just compared your GIF with the actual mockup, i feel like the cards do not look as they are in mockups.

laxyapahuja commented 4 years ago

Yeah, the mock-up has very less padding which makes it look congested.

rchtgpt commented 4 years ago

@laxyapahuja, you can avoid importing bell.png file and instead use the bell icon which is already present in the app with the name ic_notifications.xml

rchtgpt commented 4 years ago

Adding a blank line at the end of each file is considered a good practice, so I suggest you can add them.

laxyapahuja commented 4 years ago

updated :)

garvit984 commented 4 years ago

Swipe Refresh can be applied for the whole fragment. Please upload a screenshot for switching between different tabs. Remove the toolbar. Bell icon is not consistent with the design.

garvit984 commented 4 years ago

@laxyapahuja There are inconsistencies in some devices in relation to the height this bottom sheet can rise.