openMF / mifos-mobile-cn

Client-facing app on top of Apache Fineract CN
https://openmf.github.io/mobileapps.github.io/
Apache License 2.0
38 stars 64 forks source link

Redesign: Add Beneficiaries and Show Beneficiaries Screen #119

Open rchtgpt opened 4 years ago

rchtgpt commented 4 years ago

Fixes Issue

Fixes #106

GIF

ezgif com-video-to-gif (12)

Description

I have not added the fonts and bottom navigation bar as they would be added in a different PR to prevent merge conflicts. I have added a sample recyclerView as well. The color of the focused button is not the same as the mockup because this looked better in terms of design and contrast.

laxyapahuja commented 4 years ago

hey @rachittt, i think you should make a recycler view completely. you can add the card design as the item and an adapter to adapt the item layout to the recycler view as I think it is part of the frontend.

rchtgpt commented 4 years ago

hey @rachittt, i think you should make a recycler view completely. you can add the card design as the item and an adapter to adapt the item layout to the recycler view as I think it is part of the frontend.

Thanks for your comment! I have added a recyclerView with dummy details :D

rchtgpt commented 4 years ago

updated!

laxyapahuja commented 4 years ago

The button says "Submit Beneficiaries" but I think it should say "Submit Beneficiary".

laxyapahuja commented 4 years ago

Also, you can see the bottom corner radius of the CardView which I think affects the UI.

rchtgpt commented 4 years ago

@laxyapahuja, thanks for pointing out! Made the changes.

laxyapahuja commented 4 years ago

hey @rachittt, I think you can add the fonts now as #114 is merged.

garvit984 commented 4 years ago

For some of the devices, the grey card just overlaps the heading. There should be a scroll view for adding a new beneficiary.

garvit984 commented 4 years ago

@rachittt Can you please look into the changes requested above by me?