Open rchtgpt opened 4 years ago
hey @rachittt, i think you should make a recycler view completely. you can add the card design as the item and an adapter to adapt the item layout to the recycler view as I think it is part of the frontend.
hey @rachittt, i think you should make a recycler view completely. you can add the card design as the item and an adapter to adapt the item layout to the recycler view as I think it is part of the frontend.
Thanks for your comment! I have added a recyclerView with dummy details :D
updated!
The button says "Submit Beneficiaries" but I think it should say "Submit Beneficiary".
Also, you can see the bottom corner radius of the CardView which I think affects the UI.
@laxyapahuja, thanks for pointing out! Made the changes.
hey @rachittt, I think you can add the fonts now as #114 is merged.
For some of the devices, the grey card just overlaps the heading. There should be a scroll view for adding a new beneficiary.
@rachittt Can you please look into the changes requested above by me?
Fixes Issue
Fixes #106
GIF
Description
I have not added the fonts and bottom navigation bar as they would be added in a different PR to prevent merge conflicts. I have added a sample recyclerView as well. The color of the focused button is not the same as the mockup because this looked better in terms of design and contrast.
[x] Run the unit tests with
./gradlew check
to make sure you didn't break anything[x] If you have multiple commits please combine them into one commit by squashing them.