redesign: add all dimens

openMF / mifos-mobile-cn

Client-facing app on top of Apache Fineract CN

https://openmf.github.io/mobileapps.github.io/

Apache License 2.0

38 stars 64 forks source link

redesign: add all dimens #123

Closed laxyapahuja closed 4 years ago

laxyapahuja commented 4 years ago

Description

I've noticed that there are similarities in dimens additions in #119, #117, #112, #110 etc. To avoid merge conflicts, I've compiled all additions into one PR. The dimens additions from all PRs can be removed after this PR gets merged.

[x] Run the unit tests with ./gradlew check to make sure you didn't break anything
[x] If you have multiple commits please combine them into one commit by squashing them.

rchtgpt commented 4 years ago

@luckyman20 all the negative dimensions are used for the bottom margin of CardView. I think it should be uniform for all the cards. Can you tell which dimension out of the three(-50,-40 and -30) should be used?

luckyman20 commented 4 years ago

@rachittt Can you please post screenshot for all 3? It would help me in accessing it better.

rchtgpt commented 4 years ago

@luckyman20 Check the screenshots in the following PRs: -30dp -> #112 -40dp -> #115 -50dp -> #118 we are using negative dimension to hide the corner radius of the CardView

luckyman20 commented 4 years ago

@rachittt -40dp looks good to me.