search

openMF / mifos-mobile-cn

Client-facing app on top of Apache Fineract CN
https://openmf.github.io/mobileapps.github.io/
Apache License 2.0
38 stars 64 forks source link

Bug in Share button #141

Closed garvit984 closed 4 years ago

garvit984 commented 4 years ago

Summary: Supposing the permission to write to external storage is not given, it'll ask for permission. When granted it should ideally call the "share image" method, but nothing happens. This is because when the Permission is being granted, it's checking for "CAMERA" permission instead of "WRITE_EXTERNAL_STORAGE" permission. It occurs when the permission is being granted initially and later, this error does not occur. Steps to reproduce:

How can we reproduce the issue? Click Account Overview Then click on Profile Image Then Share button Expected Behaviour

When the Permission is granted for the first time, it should perform the "share" feature without requiring the user to click on the share icon in the app bar. (1 Click on "share" is expected)

Observed Behaviour

When the Permission is granted for the first time, nothing happens. The user has to again click on the "share" icon in-app bar to use the share feature. (2 Clicks on "share" is required)

Device and Android version:

Redmi 7A Android-9

Screenshots: share_first_time

garvit984 commented 4 years ago

I'll be working on it

garvit984 commented 4 years ago

@ivary43

prajwal27 commented 4 years ago

I'll also try to work on this issue.

prajwal27 commented 4 years ago

@garvit984 This is a issue related to sharing of profile image and not the app.

garvit984 commented 4 years ago

I need to tell you that as per contribution guidelines, if someone else is already working on an issue, you need to first ask that person whether he is continuing or not. I suppose that you will keep this in mind. Or, you have to report your own issues.

prajwal27 commented 4 years ago

@garvit984 Please do not delete your comments. It'll confuse other people when they go through the issue. Also, the issue was created 9 days back and hence thought of contributing. I'll keep this in mind.