Redesign - Githubissues

openMF / mifos-mobile-cn

Client-facing app on top of Apache Fineract CN

https://openmf.github.io/mobileapps.github.io/

Apache License 2.0

38 stars 64 forks source link

Redesign #165

Closed sabya48 closed 4 years ago

sabya48 commented 4 years ago

Fixes #Issue_Number

Please Add Screenshots If there are any UI changes.

Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Run the unit tests with ./gradlew check to make sure you didn't break anything
[x] If you have multiple commits please combine them into one commit by squashing them.

sabya48 commented 4 years ago

change in colour and lenght of username and password

sabya48 commented 4 years ago

commit

sabya48 commented 4 years ago

minor change

garvit984 commented 4 years ago

@sabya48 Why there are so many commits in one PR? Try to squash them into single commit.

garvit984 commented 4 years ago

@sabya48 You are not following the contribution guidelines. First you should report a issue and also check for similar existing issues. Then you should make a PR with a single commit. If you want to work on issues reported by someone else, then you must ask that person if he is continuing that or not. If the persons says that he is no longer working on it, then only you can work on that issue.

sabya48 commented 4 years ago

I am really sorry for that. I will squash all the commit into single.

rchtgpt commented 4 years ago

hello @sabya48, if you do not fix this PR in the next three days, we will have to close it because of inactivity -- as it is restricting other contributors from fixing the issue.

sabya48 commented 4 years ago

@rachittt i am sorry for for messing up all my commits. i will try to fix it as possible. i am having a problem in my PC. i will try to do it fast

rchtgpt commented 4 years ago

Closing this because of inactivity.