search

openMF / mifos-mobile-cn

Client-facing app on top of Apache Fineract CN
https://openmf.github.io/mobileapps.github.io/
Apache License 2.0
39 stars 64 forks source link

Bug: Add a confirmation dialog in forgot passcode #86

Closed rchtgpt closed 4 years ago

rchtgpt commented 4 years ago

Summary: When user clicks on "Forgot passcode, login manually", he is directed to login page directly. However a cofirmation dialog should confirm whether he/she really wants to login manually. This will enhance the User Experience.

Steps to reproduce:

  1. Go to Passcode Activity
  2. Click on "Forgot passcode, login manually" button
  3. You will be directed to the Login Activity

Expected behaviour: Before directing to the login activity, a dialog should pop up to confirm the action. Observed behaviour: .No Confirmation takes place

Device and Android version:

Device - Mi A2 Android 9 Pie

GIF: ezgif com-video-to-gif (6)

rchtgpt commented 4 years ago

Can I start working on this issue ? @abhijitramesh @harshshinde07

harshshinde07 commented 4 years ago

@rachittt Unless and until any critical action is taking place, I don't really think there is a need for any kind of confirmation dialog. This situation does not cause any harm as such.

Take an example of log out button, when user logs out, he/she has to manually re-enter the login credentials. This task is critical as the user might have clicked the log out by mistake or even have forgotten the credentials. Only in such critical tasks we need a confirmation dialog.

rchtgpt commented 4 years ago

@harshshinde07 if a person clicks on the forgot passcode button by mistake, he has to manually enter the password as well as set up a new passcode and then confirm that passcode. I just thought maybe adding a confirmation dialog as we did in 'Mifos Mobile' would enhance the user experience of the User.

harshshinde07 commented 4 years ago

Does it go back to the passcode activity on pressing back button?

rchtgpt commented 4 years ago

@harshshinde07 as of now, nope

harshshinde07 commented 4 years ago

I personally don't think adding the dialog here is a good practice. So just redirecting it back to passcode should work for now. What are your thoughts @luckyman20 ?

luckyman20 commented 4 years ago

@harshshinde07 well, we can add a confirmation dialog.

@rachittt Go ahead :)

rchtgpt commented 4 years ago

Cool! @luckyman20 Can you assign this task to me while I work on it ?

luckyman20 commented 4 years ago

@rachittt Well, it is not necessary that you contribute through tasks only.