openMF / mifos-mobile

Repository for the Mifos Mobile Banking App for clients
https://openmf.github.io/mobileapps.github.io/
Mozilla Public License 2.0
281 stars 691 forks source link

Savings Account Application is not Withdrawn #1656

Open rutvik-panchal opened 3 years ago

rutvik-panchal commented 3 years ago

Summary:

Savings Account Application is not withdrawn

Steps to reproduce:

Go to Accounts -> Any account which is not approved -> Withdraw Savings Account -> Submit with any reason

Expected behaviour:

Savings Account Application should be withdrawn

Observed behaviour:

Saving Account Application is not withdrawn

Device and Android version:

Vivo V17 Android Version 10

Screenshots:

https://user-images.githubusercontent.com/39809059/103169111-06510c80-485f-11eb-9c1b-05d97a6d2326.mp4

divyank00 commented 3 years ago

This is a backend issue, the only thing we can improve is after successful withdraw, we can finish the activity which says approval pending

rutvik-panchal commented 3 years ago

This is a backend issue, the only thing we can improve is after successful withdraw, we can finish the activity which says approval pending

@divyank00 Yes, It's a backend issue. The screen is also changing after withdraw application submit, so i don't think it's necessary to kill the details activity of #1693 that would create a bad user experience.

divyank00 commented 3 years ago

This is a backend issue, the only thing we can improve is after successful withdraw, we can finish the activity which says approval pending

@divyank00 Yes, It's a backend issue. The screen is also changing after withdraw application submit, so i don't think it's necessary to kill the details activity of #1693 that would create a bad user experience.

Why would you show the user a deleted account.

Assume you have opened a whatsapp chat and the click "Delete Chat", then it wont be there in your recently messaged also. So when backend fixes, after withdrawal, the item won't be in the list

rutvik-panchal commented 3 years ago

@divyank00 Well, use cases for both the application's are much different, here we are dealing with financial records/details which is important so just a overview is necessary. Also let's leave this thing to project maintainers.

rutvik-panchal commented 3 years ago

@miPlodder There is a change in API link.

In the current implementation we are passing savingsAccountNumber ref, i tried to update the api changes(i.e by passing savingsId) but there is some backend issue. I am getting 405 Error - Method Not Allowed.

Screenshot : Screenshot 2021-01-14 at 9 54 05 AM

miPlodder commented 3 years ago

@rutvik-panchal

rutvik-panchal commented 3 years ago

@miPlodder Self Loans do not have any method for withdrawal of savings account, what should i do? link

PratyushSingh07 commented 1 year ago

Its been long since there has been activity on this. I will take up this issue