Feat: Implement Shimmer while user details are being loaded

openMF / mifos-mobile

Repository for the Mifos Mobile Banking App for clients

https://openmf.github.io/mobileapps.github.io/

Mozilla Public License 2.0

272 stars 680 forks source link

Feat: Implement Shimmer while user details are being loaded #2412

Open PratyushSingh07 opened 11 months ago

PratyushSingh07 commented 11 months ago

Summary:

I would love to implement a shimmer that is displayed while the details are being loaded.

Steps to reproduce:

When you open the mobile application then the layout showing the user image and name are empty at first because they are being loaded. At such a point a shimmer effect would be good to have.

ShivanshKumar4265 commented 11 months ago

@PratyushSingh07 I want to work on this issue, please assign me.

PratyushSingh07 commented 11 months ago

Sure , go ahead

ghost commented 11 months ago

@CodeXstalker Are you still working on it...?if not i can work on this

ShivanshKumar4265 commented 11 months ago

@Thanush66 I am working on it

kmanikanta335 commented 10 months ago

can i work on this issue @PratyushSingh07 ?

PratyushSingh07 commented 10 months ago

@CodeXstalker are you still working on it ? please give us an update about your progress. If there hasnt been any progress then I would like to re-assign it to someone else

Also @kmanikanta335 , if @CodeXstalker gives up on this issue then it will be assigned to @Thanush66 since he had asked earlier. You will be assigned this issue only if these 2 no longer work on it

kmanikanta335 commented 10 months ago

@PratyushSingh07 In that case please assign me any other good first issues, I would like to contribute

ShivanshKumar4265 commented 10 months ago

@PratyushSingh07 you can assign to others.

PratyushSingh07 commented 10 months ago

@Thanush66 , do you want to work on it ? if not then I will pass this to @kmanikanta335

ghost commented 10 months ago

@PratyushSingh07 Yeah I will be working on it..

kmanikanta335 commented 10 months ago

hey @PratyushSingh07 unfortunately I have completed my work on this issue can I make a pullrequest

https://github.com/openMF/mifos-mobile/assets/118070186/d2776712-a4fc-4682-bc33-890f3f27ba39

PratyushSingh07 commented 10 months ago

No @kmanikanta335, you cannot make a PR as this isn't assigned to you. Also this isn't where I was expecting the shimmer. I wanted that in the home screen when the user image and text is being loaded. So your PR won't be able to solve the exact issue

kmanikanta335 commented 10 months ago

@Thanush66 yeah can you solve this issue ? if yes how many days ? I can solve this in one day please leave this to me , I really want to become an contributor since I am new and you already an contributor

jarvision-git commented 10 months ago

Hi, I have worked on this issue and want your feedback. I know I haven't been assigned to the case, but I worked on this issue to gain insight into how the app functions.

I have set the network type to UMTS so that the shimmer effect is properly visible while the data is being fetched. (u can skip to 30 sec after a few seconds into the video)

https://github.com/openMF/mifos-mobile/assets/85576130/745e8ae4-9145-4c55-a49b-10cecb305e58

This is how it would look like in Full network:

https://github.com/openMF/mifos-mobile/assets/85576130/91aeee26-a2f8-4a7a-8f67-2dc4a925eb4e

@PratyushSingh07, please share your review on this

ps: I don't expect this to be merged. I only worked on the issue to have a better understanding of the app since I'm very new to open source.

PratyushSingh07 commented 10 months ago

Awesome job @jarvision-git , the effect being showcased in full network is what I actually want.

kmanikanta335 commented 10 months ago

@Thanush66 yeah are u still working on it ?

ghost commented 10 months ago

@PratyushSingh07 Can you re-assign it.?

PratyushSingh07 commented 10 months ago