search

openMF / mifos-mobile

Repository for the Mifos Mobile Banking App for clients
https://openmf.github.io/mobileapps.github.io/
Mozilla Public License 2.0
274 stars 682 forks source link

Feat: edit button in user profile screen #2460

Open PratyushSingh07 opened 9 months ago

PratyushSingh07 commented 9 months ago

Summary:

There is an edit button in user profile screen which was also present in the intital xml design. However there hasn't been any implementation of that button.

Steps to reproduce:

Expected behaviour:

Observed behaviour:

Device and Android version:

Device: Pixel 7 Android: 14

Screenshots: modified dark

PratyushSingh07 commented 9 months ago

@therajanmaurya any suggestions ?

ashutosh-kumar-kushwaha commented 9 months ago

I want to work on this. Please assign this to me. @PratyushSingh07

PratyushSingh07 commented 9 months ago

Hey @ashutosh-kumar-kushwaha this issue has been labelled as community discussion which means that we are yet to decide the functionality of this feature. This cannot be assigned until we have a clear idea of what needs to be implemented

Ronitrs5 commented 9 months ago

Hey @PratyushSingh07. So, when clicked on the top right pencil (edit) icon, the data that was changed should be changed, but nothing changes. So we just need to check the java/kotlin code regarding to that button and what logic is written on the setOnClickListener() method. So you can assign this to me.

PratyushSingh07 commented 9 months ago

We haven't implemented the logic for this @Ronitrs5 . Also this screen is now in compose so you won't exactly find a setOnClickListener() .

Ronitrs5 commented 9 months ago

Ohh I see, my apologies @PratyushSingh07 for not knowing that it was built on compose. However, I can work on the functionality when button is pressed if the logic was known to me. (I assume we want to save the updates)

shalenMathew commented 9 months ago

We haven't implemented the logic for this @Ronitrs5 . Also this screen is now in compose so you won't exactly find a setOnClickListener() .

so are u asking to create a dummy class to test if the button functionality will work as expected?

r1shhh1 commented 7 months ago

@PratyushSingh07 i would like to work on this issue

PratyushSingh07 commented 7 months ago

hey @r1shhh1 , we still arent sure regarding the functionality of this feature hence I have put this under community discussion. You can open issues regarding xml to compose migration as this is what we are focusing on

r1shhh1 commented 7 months ago

Sure @PratyushSingh07

yashc18 commented 3 days ago

is functionality of this feature decided?