Closed therajanmaurya closed 5 months ago
I would like to do this task, can I be assigned with it?
@therajanmaurya can i work on this issue ?
Hey @Akshay2004-701, as you commented first, so please directly make a PR and send the PR link in the Slack Channel. Thanks!
@Akshay2004-701 Can I go with this if you're okay with it?
ok, sure
Thank you @Akshay2004-701 . @PratyushSingh07 Please assign this to me.
Go ahead @Vikashgathala
@PratyushSingh07 Do I need to add the screenshots of the same screens and in the same order as previous ones? I am unable to add beneficiaries so same activities with new UI isnt possible right now.
In that case add UI of those screens that are visible
@PratyushSingh07 Have a look at this. LGTM.
Instead of loan account details we can show Help section. Moreover, I would prefer having something similar to the one used in Android client. Let me know if you can replicate that
@PratyushSingh07 I'll do this by evening.
Great, thanks
@PratyushSingh07 Done.
Lgtm @Vikashgathala . Can you just replace the current help section screenshot with the one in which we can have some of the answers as well. I mean can you expand a few of them . It would look better imo. Let me know if you think otherwise
There is no UI separation between the help section's question and solution after expanding. I tried that but it looks like a single paragraph. This looks a little better and we have any ui improvements in help section in future, it would be better to update it in this. also, I have squashed the commits and its ready from my side until you find it mandatory to update the screenshots as you are recommending. Let me know what you think. @PratyushSingh07
Lgtm , we can go ahead with this. Please open a PR. It seems that you have just pushed the changes to your fork and haven't actually opened the PR
Summary:
Summarize your issue in one sentence (what goes wrong, what did you expect to happen).
Steps to reproduce:
How can we reproduce the issue?
Expected behaviour:
What did you expect the app to do?
Observed behaviour:
What did you see instead? Describe your issue in detail here.
Device and Android version:
What make and model device (e.g., Samsung Galaxy S3) did you encounter this on? What Android version (e.g., Android 4.0 Ice Cream Sandwich or Android 6.0 Marshmallow) are you running? Is it the stock version from the manufacturer or a custom ROM?
Screenshots:
Can be created by pressing the Volume Down and Power Button at the same time on Android 4.0 and higher.