search

openMF / mifos-mobile

Repository for the Mifos Mobile Banking App for clients
https://openmf.github.io/mobileapps.github.io/
Mozilla Public License 2.0
270 stars 674 forks source link

refactor: migrated savings account application screen to compose #2522

Closed AvneetSingh2001 closed 5 months ago

AvneetSingh2001 commented 6 months ago

Fixes #2521

Please Add Screenshots If there are any UI changes.

Before(XML Screen): https://github.com/openMF/mifos-mobile/assets/77102514/91c990b5-e8ff-47c8-865e-2893fe0461cd

After(Compose Screen): https://github.com/openMF/mifos-mobile/assets/77102514/f17bc7d2-84e8-4099-8a6a-53e355685db1

therajanmaurya commented 5 months ago
image

This screen does not follow the material guideline, please give 16dp padding from left and right.

AvneetSingh2001 commented 5 months ago

hey, thats screenshot is actually the previous design in XML, that doesn’t have the padding.

I have already given the padding in Compose design, you can check Compose screen recording here: https://github.com/openMF/mifos-mobile/assets/77102514/f17bc7d2-84e8-4099-8a6a-53e355685db1