openMF / mifos-mobile

Repository for the Mifos Mobile Banking App for clients
https://openmf.github.io/mobileapps.github.io/
Mozilla Public License 2.0
274 stars 686 forks source link

Fix Syntax Errors and Improve Unit Test Coverage #2528

Closed NiranjanNlc closed 7 months ago

NiranjanNlc commented 7 months ago

Fixes #2527

In this pull request, I address the syntax errors present in some of unit test files and improve the est coverage of the Android project .

NiranjanNlc commented 7 months ago

Hi @PratyushSingh07 and @therajanmaurya , Please just review this PR. since, i need to rewrite some of the approach , i just want to validate from you people that every thing is upto par .

Under approval of yours , i will apply these in other classes too . Thanks

PratyushSingh07 commented 7 months ago

I believe you should probably use turbine to write unit tests as we are using kotlin flows

NiranjanNlc commented 7 months ago

I believe you should probably use turbine to write unit tests as we are using kotlin flows

Thanks @PratyushSingh07 for suggestion.

NiranjanNlc commented 7 months ago

hey @PratyushSingh07 , I have used the turbine for testing flow .

Any feedback from your side ??

therajanmaurya commented 7 months ago

I can see you have deleted so many ViewModel unit test why?

NiranjanNlc commented 7 months ago

I can see you have deleted so many ViewModel unit test why?

I just want to make sure the approach i followed now is upto par . I will add them if you validate this approach . Shall i go with these approach now ? You can merge PR after i added all of them . Thanks .

NiranjanNlc commented 7 months ago

I can see you have deleted so many ViewModel unit test why?

hey @therajanmaurya , I have added all of the test files for now . and all of the test are passed . Please get it reviewed now thanks