openMF / mifos-mobile

Repository for the Mifos Mobile Banking App for clients
https://openmf.github.io/mobileapps.github.io/
Mozilla Public License 2.0
259 stars 664 forks source link

fix: currency display symbol null #2559

Closed AbrahamOsmondE closed 4 months ago

AbrahamOsmondE commented 4 months ago

Fixes #2433

Fix for Albanian LEK, previously showing null:

Before: Screenshot 2024-03-30 at 1 17 40 AM

After: Screenshot 2024-03-30 at 1 12 30 AM

Please make sure these boxes are checked before submitting your pull request - thanks!

AbrahamOsmondE commented 4 months ago

The list of currency are taken from a DB Sql, whose implementation defers from tenant to tenant. An the default currency list and properties can be found here

It seems that MySQL does not support some of these currency symbols (source), causing displaySymbol to be null for some currencies.

We should instead implement a fallback for these cases